Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Migrating against 10.3.49 produces a repo that fails restore with NU1903 (resolved by 10.4.0 GA)

未关闭
#618 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 5 天内回复

还没有人认领这个 Issue。

评估

难度
1/5
预计耗时
1-3 小时
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
冷清
技术栈
csharp
领域
build-system

调研方向

针对 10.4.0 GA 运行一次全新的 fallout-migrate,然后在配置了 TreatWarningsAsErrors 的使用者存储库中运行 ./build.ps1。检查还原是否在没有 NU1903 的情况下完成,并在 10.4.0 GA 发布后关闭 issue。

由索引模型根据 Issue 内容生成。

描述

bug target/vCurrent

@

Problem

Running fallout-migrate today produces a consumer repo that cannot restore. Two behaviours combine:

  1. ResolveFalloutVersionStep pins the latest stable release within the tool major → 10.3.49. Fallout.Common 10.3.49 depends on System.Security.Cryptography.Xml 10.0.6, which carries five high-severity advisories (GHSA-23rf-6693-g89p, GHSA-8q5v-6pqq-x66h, GHSA-cvvh-rhrc-wg4q, GHSA-g8r8-53c2-pm3f, GHSA-mmjf-rqrv-855v).
  2. RewriteCsprojsStep deliberately strips the consumer's explicit System.Security.Cryptography.Xml pin (intentional, #217, to avoid NU1605 downgrade errors).

So the migration removes the consumer's protection and pins them to the vulnerable transitive. On a repo with TreatWarningsAsErrors, ./build.ps1 fails restore immediately with 5× NU1903.

Reproduced end-to-end on FluentAssertions at its last NUKE commit (3eacba9^) with the 10.4.0-rc.5 tool. Corroborating evidence: FluentAssertions' own hand-done migration had to re-add System.Security.Cryptography.Xml 10.0.10 with a comment naming exactly this NU1903.

Outcome

No code change requested — 10.4.0 GA resolves this. Fallout.Common 10.4.0-rc.5 already depends on the patched System.Security.Cryptography.Xml 10.0.10, and ResolveFalloutVersionStep picks the latest stable in-major, so once 10.4.0 ships the migration will pin 10.4.0 and restore cleanly.

Filed to record the diagnosis so the 10.4 release notes can point consumers at it, and so the interaction is on record if the strip-the-pin behaviour is ever revisited for older targets.

Acceptance criteria

  • Confirm a fresh fallout-migrate run against 10.4.0 GA restores cleanly on a TreatWarningsAsErrors consumer
  • Close on 10.4.0 GA publish
    @
主要语言
C#
星标
169
派生
21
平均合并
3 天 7 小时
30 天内合并 PR
9

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Fallout-build/Fallout 的其他 Issue

查看 Fallout-build/Fallout 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。