Tuple.map: accept ordinary callbacks while preserving tuple length
维护者通常 1 天内回复
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 72/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript
调研方向
Start with Tuple.map in the tuple module and the existing overloads; the issue specifies adding ordinary callback overloads after the Lambda overloads, with no runtime change. Read the type tests in packages/effect/typetest/Tuple.tst.ts and runtime tests in packages/effect/test/Tuple.test.ts, then run them. Done when the listed tuple type behaviors pass and Lambda behavior remains intact.
由索引模型根据 Issue 内容生成。
描述
Problem
Tuple.map only accepts a Struct.Lambda. Mapping a fixed-length tuple with an ordinary function is rejected, and the only way to keep the length today is to declare a Lambda interface for a one-line callback:
import { Tuple } from "effect"
const xs = [1, 2, 3] as [number, number, number]
// Error: '(n: number) => number' does not satisfy 'Struct.Lambda'
Tuple.map(xs, (n) => n + 1)
// Works, but needs an interface + Struct.lambda for a trivial callback
interface Inc extends Struct.Lambda {
(n: number): number
readonly "~lambda.out": number
}
Tuple.map(xs, Struct.lambda<Inc>((n) => n + 1)) // [number, number, number]
Array.map(xs, (n) => n + 1) works but returns Array<number>, losing the length. Requested by TheStockBroker on Discord.
Accepted design
Add ordinary-callback overloads to Tuple.map, placed after the existing Lambda overloads. The callback receives the element union T[number] and every position in the result becomes the callback's return type, through the same homomorphic mapped type the Lambda overloads already use:
export const map: {
// existing Lambda overloads, unchanged and first
<L extends Lambda>(lambda: L): <const T extends ReadonlyArray<unknown>>(self: T) => { [K in keyof T]: Apply<L, T[K]> }
<const T extends ReadonlyArray<unknown>, L extends Lambda>(self: T, lambda: L): { [K in keyof T]: Apply<L, T[K]> }
// new
<A, B>(f: (a: A) => B): <const T extends ReadonlyArray<A>>(self: T) => { [K in keyof T]: B }
<const T extends ReadonlyArray<unknown>, B>(self: T, f: (a: T[number]) => B): { [K in keyof T]: B }
}
No runtime change: the implementation is already self.map((e) => lambda(e)).
Behaviour
Tuple.map([1, 2, 3] as [number, number, number], (n) => n + 1)is[number, number, number].pipe(xs, Tuple.map((n: number) => n + 1))is[number, number, number]. As withArray.map, the data-last callback needs an annotated parameter; an unannotated one isunknown.- Heterogeneous tuples work:
Tuple.map(["a", 2, true] as [string, number, boolean], (x) => String(x))is[string, string, string], and the callback parameter isstring | number | boolean. A callback whose parameter is narrower than the element union is rejected. - The homomorphic mapped type keeps
readonly, optional slots ([string?, number?]maps to[B?, B?]), rest elements, and the empty tuple. - Literals are not falsely preserved:
Tuple.map([1, 2, 3] as const, (n) => n + 1)isreadonly [number, number, number](readonlybecauseconst Tinfers the literal as a readonly tuple, matching the existing Lambda overload). - Lambda behaviour is unchanged.
Tuple.map(schemas, Schema.NullOr)still tracks each position separately.
Decisions
Element union instead of a Homogeneous<T> guard. The Discord sketch proposed a type-level check that every slot equals T[number]. It is not needed for soundness: the callback is called with each element, every element is in T[number], and every result slot is B. The guard would only reject sound programs such as the heterogeneous example above and add a conditional type to every call. Dropped.
Lambda overloads stay first. The two data-first overloads share arity 2, so order matters. Callback-first breaks Lambdas: a generic Lambda such as Schema.NullOr satisfies (a: T[number]) => B, so TypeScript picks the callback overload and collapses every slot to NullOr<String | Number | Boolean>. Lambda-first does not have the mirror problem: a plain arrow does not satisfy the Lambda constraint, so it falls through to the callback overload, and the arrow's parameter is still contextually typed from T[number] (verified on TypeScript 5.9, 6.0 and 7.1: identity callbacks infer [number, number, number], not any).
Alternatives probed and rejected: callback-first with a & { readonly "~lambda.in"?: never } guard on the callback parameter (works, but encodes a Lambda internal into the public signature), and a single signature with F extends Lambda | ((a: T[number]) => unknown) and a conditional result type (works, but hides which path applies and worsens error messages). Both pass the same probe as the accepted design with no advantage.
Out of scope
Struct.map, Tuple.mapPick and Tuple.mapOmit have the same Lambda-only restriction. Same pattern would apply; separate issue if wanted.
Tests
Type tests in packages/effect/typetest/Tuple.tst.ts and a runtime test in packages/effect/test/Tuple.test.ts cover the behaviour above and currently fail on the type side.
- 主要语言
- TypeScript
- 星标
- 16.7k
- 派生
- 808
- 平均合并
- 17 小时 9 分钟
- 30 天内合并 PR
- 825
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Effect-TS/effect 的其他 Issue
-
Arbitrary.schema: no generation override for a struct's cross-field filter, and lookahead patterns are skipped quietly可能已有人在做 @effect-bot 于 1 天前认领。 未关闭
Effect-TS/effect#10479 · 已指派 1 人 ·
维护者通常 1 天内回复
-
`Cookies` drops same-name cookies set for a different domain or path可能已有人在做 @effect-bot 于 2 天前认领。 未关闭
Effect-TS/effect#10469 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Schema: a public way to derive a canonical codec, as `toCodecJson` and `toCodecStringTree` do可能已有人在做 @effect-bot 于 3 天前认领。 未关闭Needs Proposal schema
Effect-TS/effect#10457 · 已指派 1 人 ·
维护者通常 1 天内回复
-
McpServer.layerHttp: optional legacy GET SSE for idle list-change notifications可能已有人在做 @effect-bot 于 3 天前认领。 未关闭
Effect-TS/effect#10436 · 已指派 1 人 ·
维护者通常 1 天内回复
-
McpServer.layerStdio: native EOF cancellation policy for active tool handlers可能已有人在做 @effect-bot 于 5 天前认领。 未关闭
Effect-TS/effect#10412 · 已指派 1 人 ·
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
home-assistant/frontend#55841 ·
维护者通常 1 天内回复
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
难度 1/5 1 小时以内 新手友好度 76/100
lingdojo/kana-dojo#33905 · 1 条评论 · 5 个 reaction ·
维护者通常 1 天内回复
-
bug(semester-planning): the edit application dialog cannot save with an empty «Annet fra bedriften»未关闭
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
blocklist removal
难度 2/5 1-3 小时 新手友好度 66/100
MetaMask/eth-phishing-detect#311215 ·
维护者通常 1 天内回复
-
Explore filter: multi-select value list with allowNewOptions stops accepting values and drops earlier ones可能已有人在做 @isaac-jaynes-imperva 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
apache/superset#46146 · 1 条评论 ·
维护者通常 2 天内回复