Horizon rate limiting is not handled

已关闭
  • 哪里不对？
#348 2 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 4 天内回复

@abdulrahmanj383-creator 已经在做这个了。

开始于 2026年10月16日。

  • #398 来自 @abdulrahmanj383-creator —— 未关闭
  • #467 来自 @sparkysolutions10-pixel —— 未关闭

评估

这个 Issue 还没有评估数据。

描述

area:ingest difficulty:intermediate help wanted points:150 Stellar Wave
Background

The AMM ingester calls Horizon directly:

const response = await fetch(
  `${getNetworkConfig(network).horizon.url}/liquidity_pools?${params.toString()}`
)
const data = await response.json() as any
if (!data._embedded?.records) return []

response.ok is never checked. A 429 from Horizon has no _embedded.records,
so it takes the same path as an empty result and the ingester reports that the
pair has no pools. Horizon publishes rate-limit headers and a Retry-After, and
none of them are read.

Under sustained rate limiting this ingester produces wrong data continuously
rather than backing off, and because of L163 the aggregate silently reweights
around it.

What to build
  • Check response.ok before parsing, everywhere Horizon is called.
  • Treat 429 distinctly: honour Retry-After when present, otherwise back off
    exponentially with jitter.
  • Surface remaining-quota headers as a gauge so approaching the limit is visible
    before it bites.
  • A 429 must not be reported as an empty venue — coordinate with L163.
Acceptance criteria
  • Non-2xx responses are detected before the body is parsed
  • 429 honours Retry-After when present and backs off otherwise
  • A rate-limited fetch is not reported as an empty result
  • Remaining quota is exported as a metric
  • Tests cover 429 with and without Retry-After

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

主要语言
TypeScript
星标
4
派生
71
平均合并
3 天 22 小时
30 天内合并 PR
142

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

Divinity-Labs/Lens 的其他 Issue

查看 Divinity-Labs/Lens 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。