Potentially a serious issue with Eigenstrat to Plink conversions

未关闭
#76 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
需要澄清
活跃度
停滞
技术栈
c

调研方向

首先跟踪 par.PED.PACKEDPED 的 convertf 路径,并比较此处所述的 Eigenstrat .snp 和 Plink .bim 等位基因列约定。检查文件合并并转换回 Eigenstrat .geno 时如何处理生成的 .bim;完成此项工作需要确认下游 Admixtools 的影响,并提供可复现的修正或记录为不存在问题。

由索引模型根据 Issue 内容生成。

描述

This issue affects conversions from Eigenstrat to Plink using convertf and par.PED.PACKEDPED. As you're aware Eigenstrat .snp follows VCF format with regards to listing the REF allele (col 5) in the column prior to the ALT allele (col 6).

However, Plink .bim does the opposite where ALT is listed in col 5 and REF in col 6.

It seems that convertf is not aware of this Plink .bim format because after I convert files from Eigenstrat .geno to Plink .bed using par.PED.PACKEDPED, ALT is still listed in col 6 and REF in col 5 of the .bim file that was just obtained from .snp.

So now when this is merged with other Plink files you have a totally mixed up final merged Plink file with REF being in col 5 for some positions and col 6 for other positions. This may not cause issues in Plink for minor allele frequency calculations but once converted back to Eigenstrat .geno may cause flawed downstream analysis.

My question is would this cause any issues with Admixtools code if REF is col 5 for some positions and col 6 for other positions and alternatively ALT in col 6 for some and col5 for other positions ?

I'm quite certain this has gone unnoticed by most researchers converting files back and forth.

主要语言
C
星标
236
派生
76
PR 合并指标
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

DReichLab/AdmixTools 的其他 Issue

查看 DReichLab/AdmixTools 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。