Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Latent defects in setools star merge, breakdown grid, create_final_cat and footprint resume

未关闭
#959 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
backend, data

调研方向

Start by reading the four named entry points: src/shapepipe/modules/merge_starcat_package/merge_starcat.py, scripts/python/run_breakdown_grid.py, scripts/python/create_final_cat.py, and src/shapepipe/utilities/field_corners_extractor.py. Check the cited lines and their related tests, if present, to understand each defect and its expected behavior. Done means each of the five reported defects is corrected and covered by checks for the affected behavior.

由索引模型根据 Issue 内容生成。

描述

Five defects outside the committed data path, found while rewriting comments (comment sweep, PR to follow) and confirmed against develop (f2ab8a56) by a second reader. None affects the fiducial pipeline (psfex PSF model, workflow/); they matter to whoever next uses these tools.

merge_starcat with psf_model = setools (src/shapepipe/modules/merge_starcat_package/merge_starcat.py)

  • l. 847–848: each input rebinds eps1, eps2, chi1, chi2, so the output carries only the last input's ellipticities while every other column is stacked across inputs.
  • l. 811: get_ellipticity tests the builtin type rather than its parameter typ, so the chi/2 branch never runs.

scripts/python/run_breakdown_grid.py — l. 92–93, 270, 334: the injected shear arms are fixed at ±0.02 (ARMS), while --gamma only sets the estimator's denominator, so any non-default --gamma misnormalises the multiplicative bias.

scripts/python/create_final_cat.py — l. 617–621: single_action() sets res = 1 when the ID is absent and then unconditionally res = 0, so the check exits 0 on a missing ID.

src/shapepipe/utilities/field_corners_extractor.py — resume (l. 320–323) treats a CCD as done once its ID appears in column 0, while each row is written in several operations (l. 415–418); an interrupted write leaves an incomplete CCD that resume then skips.

Claude (Opus) and GPT-6.1 Sol on behalf of Cail.

主要语言
Python
星标
18
派生
14
平均合并
2 天 13 小时
30 天内合并 PR
35

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

CosmoStat/shapepipe 的其他 Issue

查看 CosmoStat/shapepipe 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。