Can Source Generators Further Simplify Synchronization in MVVM Community Toolkit
还没有人认领这个 Issue。
评估
调研方向
未指定任何仓库文件、测试或生成器入口点。首先检查现有 ObservableProperty 源代码生成器的行为以及提议的同步属性,然后确定所请求的声明式属性和集合连接是否可行。完成标准是确定一套双方认可的 API,以及包含循环防止在内的生成式双向同步行为。
由索引模型根据 Issue 内容生成。
描述
Overview
I’m using the MVVM Community Toolkit to keep a ViewModel synchronized with a Model, handling both properties and collections. The [ObservableProperty] attribute already simplifies INotifyPropertyChanged implementation, but bidirectional synchronization between the ViewModel and Model still requires manually writing event handlers and update logic. This becomes repetitive and prone to errors, especially with multiple properties or collections.
Current Code:
Here’s my current ViewModel implementation, which synchronizes a Name property and an Items collection with a Model:
using CommunityToolkit.Mvvm.ComponentModel;
using System.Collections.ObjectModel;
using System.Collections.Specialized;
public partial class ViewModel : ObservableObject
{
private readonly Model model;
private bool isSyncing = false;
[ObservableProperty]
private string name;
[ObservableProperty]
private ObservableCollection<string> items = new ObservableCollection<string>();
public ViewModel(Model model)
{
this.model = model;
// Initialize properties from the Model
Name = model.Name;
// Initialize the collection from the Model
foreach (var item in model.Items)
{
Items.Add(item);
}
// Sync properties: Update ViewModel when Model changes
model.PropertyChanged += (sender, e) =>
{
if (e.PropertyName == nameof(Model.Name))
{
Name = model.Name;
}
};
// Sync collections: Update ViewModel.Items when Model.Items changes
model.Items.CollectionChanged += (sender, e) =>
{
if (!isSyncing)
{
isSyncing = true;
if (e.Action == NotifyCollectionChangedAction.Add)
{
foreach (string item in e.NewItems)
{
Items.Add(item);
}
}
else if (e.Action == NotifyCollectionChangedAction.Remove)
{
foreach (string item in e.OldItems)
{
Items.Remove(item);
}
}
isSyncing = false;
}
};
// Sync collections: Update Model.Items when ViewModel.Items changes
Items.CollectionChanged += (sender, e) =>
{
if (!isSyncing)
{
isSyncing = true;
if (e.Action == NotifyCollectionChangedAction.Add)
{
foreach (string item in e.NewItems)
{
model.Items.Add(item);
}
}
else if (e.Action == NotifyCollectionChangedAction.Remove)
{
foreach (string item in e.OldItems)
{
model.Items.Remove(item);
}
}
isSyncing = false;
}
};
}
// Sync properties: Update Model when ViewModel's Name changes
partial void OnNameChanged(string value)
{
model.Name = value;
}
}
Issue:
While functional, this code involves a lot of boilerplate:
- Manual event subscriptions for
PropertyChangedandCollectionChanged. - Explicit initialization of properties and collections from the Model.
- Repeated logic to update one side when the other changes, including an
isSyncingflag to avoid infinite loops.
Question:
Could the MVVM Community Toolkit leverage source generators to eliminate this boilerplate? I’d love to see a solution where synchronization is defined declaratively (e.g., via attributes), and the source generator handles all the event wiring and updates behind the scenes.
API breakdown
How It Could Work:
[SyncWithModel(typeof(Model))]specifies that this ViewModel synchronizes with theModelclass.[SyncProperty("Name")]marks thenameproperty for bidirectional synchronization withModel.Name.[SyncCollection("Items")]marks theitemscollection for bidirectional synchronization withModel.Items.
The source generator could then:
- Initialize
nameanditemsfrom the Model in the constructor. - Subscribe to
PropertyChangedon the Model to updatename. - Subscribe to
CollectionChangedon bothModel.ItemsandViewModel.Itemsfor two-way updates. - Generate the update logic with an
isSyncingguard to prevent infinite loops.
Usage example
Hypothetical Example:
Here’s what I envision the code could look like with source generators:
using CommunityToolkit.Mvvm.ComponentModel;
[SyncWithModel(typeof(Model))]
public partial class ViewModel : ObservableObject
{
private readonly Model model;
public ViewModel(Model model)
{
this.model = model;
}
[SyncProperty("Name")]
[ObservableProperty]
private string name;
[SyncCollection("Items")]
[ObservableProperty]
private ObservableCollection<string> items = new ObservableCollection<string>();
}
Breaking change?
No
Alternatives
None
Additional context
Would the MVVM Community Toolkit team consider adding this kind of source-generator-based synchronization? It would make the code much cleaner and more maintainable. If this is doable, what challenges might arise in implementing it? Alternatively, if there’s an existing way to achieve this with less boilerplate, I’d appreciate pointers or examples.
Help us help you
No, just wanted to propose this
- 主要语言
- C#
- 星标
- 3.8k
- 派生
- 403
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
CommunityToolkit/dotnet 的其他 Issue
-
RelayCommand<T>.CanExecute(null) returns false for value types without a predicate可能已有人在做 @apachezy 于 93 天前认领。 未关闭bug :bug:
难度 2/5 1-3 小时 新手友好度 84/100
CommunityToolkit/dotnet#1206 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
CommunityToolkit/dotnet#1186 ·
-
bug :bug:
难度 1/5 1 小时以内 新手友好度 68/100
CommunityToolkit/dotnet#648 ·
-
难度 5/5 一周以上 新手友好度 35/100
CommunityToolkit/dotnet#1217 ·
-
bug :bug:
难度 3/5 1-2 天 新手友好度 68/100
CommunityToolkit/dotnet#1215 · 2 条评论 ·
查看 CommunityToolkit/dotnet 的全部 Issue
相似的 Issue
-
good first issue
难度 1/5 1 小时以内 新手友好度 88/100
madeyoga/AuthEndpoints#365 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 76/100
majorsilence/Reporting#493 ·
维护者通常 1 天内回复
-
area: backend enhancement payments
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 4 天内回复