AdaptiveProgressBar serializes Value attribute using system culture instead of InvariantCulture (breaks Toast progress bar on non-US locales)

未关闭 适合新手
  • 哪里不对？
#888 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
75/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
csharp
领域
desktop-dev

调研方向

找到 AdaptiveProgressBar 类型以及将其 Value 属性序列化到 toast XML 中的代码。使用 de-DE 之类的区域设置和 0.5 的值复现问题，然后添加或更新回归测试，检查序列化后的 value 是否使用 . 作为小数分隔符。完成的标志是，在使用逗号作为小数分隔符的区域设置下，进度条 XML 中仍包含 value="0.5"，并且现有的 toast 序列化测试继续通过。

由索引模型根据 Issue 内容生成。

描述

Describe the bug

When using ToastContentBuilder.AddProgressBar on a Windows machine with a regional culture that uses a comma as a decimal separator (such as Russian ru-RU, German de-DE, French fr-FR, etc.), the resulting XML for the Toast notification is generated with a comma instead of a dot.
Windows Notification Center strictly expects a dot separator (.) for fractional values in XML attributes. Because it fails to parse the comma (,), the progress bar on the screen is always rendered as completely empty (0%) for any value between 0.0 and 1.0. The only exception is exactly 1.0, which happens to work because it formats as a whole integer "1" without any fractional digits.

Environment & Conditions

• OS: Windows 10 / Windows 11
• Critical Condition: Windows Regional Format must be set to a culture that uses a comma as a decimal separator (e.g., German, Spanish, Russian).
• Framework: .NET 8 / .NET 9 / .NET 11 (Windows SDK)
• Library: CommunityToolkit.WinUI.Notifications (or Microsoft.Toolkit.Uwp.Notifications)

Steps to reproduce
1. Change the OS thread culture or Windows Regional Format to Russian (ru-RU) as sample.
2. Execute the following C# code to build a toast notification:

using CommunityToolkit.WinUI.Notifications;

var tb = new ToastContentBuilder()
    .AddText("UPS Status")
    .AddProgressBar("Battery Charge", 0.5); // Expected 50% progress

// Extract the raw XML generated by the toolkit
Windows.Data.Xml.Dom.XmlDocument xDoc = tb.GetToastContent().GetXml();
string serializedXml = xDoc.GetXml();

System.Console.WriteLine(serializedXml);

When inspecting the serializedXml string, you will see that the <progress> tag has a comma in its value:

xml: <progress value="0,5" title="Battery Charge" ... />

Because of value="0,5", Windows Notification Center drops the value to 0, and the UI shows an empty progress bar.
Expected behavior

The toolkit should always serialize the Value property inside AdaptiveProgressBar using CultureInfo.InvariantCulture, regardless of the user's current OS locale. The output should look like this:

xml: <progress value="0.5" title="Battery Charge" ... />

Screenshots

No response

Code Platform
  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK
Windows Build Number
  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Windows 11 22H2 (Build 22621)
  • Windows 11 23H2 (Build 22631)
  • Windows 11 24H2 (Build 26100)
  • Windows 11 25H2 (Build 26200)
  • Windows 11 26H1 (Build 28000)
  • Other (specify)
Other Windows Build number

No response

App minimum and target SDK version
  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Windows 11, version 24H2 (Build 26100)
  • Windows 11, version 25H2 (Build 26200)
  • Windows 11, version 26H1 (Build 28000)
  • Other (specify)
Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

主要语言
C#
星标
1.1k
派生
168
平均合并
2 小时 48 分钟
30 天内合并 PR
2

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

CommunityToolkit/Windows 的其他 Issue

查看 CommunityToolkit/Windows 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。