Profiled width candidates can deliver twice their advertised intrinsic width with Retina Quality
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 45/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- javascript, php, wordpress
- 领域
- frontend, performance, web-dev
调研方向
从 assets/js/modules/srcset-detector.js 中的 _generateResponsiveSizes() 开始,然后跟踪 inc/tag_replacer.php 中的 add_missing_srcset_attributes()、change_url_for_size() 和 filter_srcset_attr()。运行 tests/test-srcset.php 和 assets/js/modules/tests/srcset-detector.test.js,然后在 DPR 1 和 2 下复现。完成的标准是:经过 profiling 的候选项不再将一个声明的宽度与一个加倍的已交付固有宽度组合在一起。
由索引模型根据 Issue 内容生成。
描述
Summary
When Retina Quality is enabled, a page-profiler-generated srcset candidate can advertise a width such as 218w while delivering a resource with an intrinsic width of 436 pixels. The advertised width is expected to match the candidate resource's intrinsic width. The mismatch can cause browser DPR selection and Optimole DPR processing to compound, substantially increasing image dimensions, transfer size, and page-load time for affected images.
Customer context
Product / area: Optimole responsive images and Retina Quality
Version: Customer version not provided; inspected source is v4.2.10
Environment: WordPress frontend; Chrome DevTools and Lighthouse on a high-density display
Integration / third party: Optimole CDN image delivery
Reported error / symptom: A candidate advertised as 218w delivered a 436-pixel-wide resource; another URL requesting width 824 reportedly delivered 1648 pixels
Impact: The customer reported oversized payloads across a photography-heavy site and a PageSpeed lab LCP improvement from 9.4s to 5.8s when Retina Quality was disabled.
Reproduction notes
Reported and independently confirmed by support on the rendered page, but not reproduced locally during repository inspection.
- Enable Retina Quality on a page where Optimole's profiler generates missing responsive candidates.
- Load the page on a high-density display and let the browser select a generated
wcandidate. - Compare the selected candidate's
wdescriptor and URL width parameter with the delivered resource's intrinsic width. - The reported
218wcandidate delivered 436 intrinsic pixels; disabling Retina Quality stopped the doubling.
Diagnosis
Conclusion
The page-profiler path records a DPR-multiplied width as a w descriptor and also retains dpr:2 for URL generation. The resulting URL contains both the multiplied width and the DPR transform while the emitted descriptor remains the stored width. The transcript includes a staff-verified runtime example where a 218w candidate delivered 436 intrinsic pixels, confirming the failing CDN interaction for the reported path.
Where this likely occurs
assets/js/modules/srcset-detector.js—optmlSrcsetDetector._generateResponsiveSizes()lines 410–460 computestargetWidth = baseWidth * dprValue, stores that value inwand the width descriptor, and separately stores the DPR value.inc/tag_replacer.php—Optml_Tag_Replacer::add_missing_srcset_attributes()lines 487–515 passes the stored width and DPR to URL generation while emitting the stored descriptor unchanged.inc/tag_replacer.php—Optml_Tag_Replacer::change_url_for_size()lines 790–810 places bothw:<stored width>anddpr:2in the transformed URL.inc/tag_replacer.php—Optml_Tag_Replacer::filter_srcset_attr()lines 824–890 shows the older non-profiler path represents its Retina candidate with a2xdensity descriptor instead.- Commit
8ab74741721cintroduced profiler-based srcset handling; commit49a757f34fd1introduced the current breakpoint/DPR generation. Both are present from v4.1.0 through inspected v4.2.10.
Engineering notes
The defect is scoped to profiler-generated width candidates where Retina entries survive filtering and the CDN applies the supplied DPR. It is distinct from WordPress-generated srcsets handled by filter_srcset_attr(), which use a density descriptor for the added Retina candidate. The CDN implementation is not available in the workspace; its doubling behavior is supported here by the staff-verified runtime output in the transcript rather than local service-source inspection.
Test coverage status
tests/test-srcset.php lines 30–60 checks URL manipulation involving dpr:2, and assets/js/modules/__tests__/srcset-detector.test.js covers DPR variation selection. No test found during inspection validates a profiled DPR entry end to end against its emitted width descriptor and delivered intrinsic dimensions. Tests were not executed during this read-only investigation.
What to verify or explore next
- Reproduce on a local WordPress page requiring profiler-generated srcset candidates with Retina Quality enabled.
- Compare emitted width descriptors, transformed URL parameters, response intrinsic dimensions, and browser candidate selection at DPR 1 and DPR 2.
- Run the targeted PHP srcset suite and JavaScript
srcset-detectorsuite. - Confirm behavior against the current Optimole CDN contract for simultaneous width and DPR parameters.
Unknowns / follow-up
The exact customer plugin version and whether cached profile data changes the first affected response are unknown.
Confidence
Confidence: 98/100
Repository inspection confirms three independently verifiable defects in Optimole's page-profiler responsive-image path, and no matching GitHub issues were found. The reported Retina-disabled 1x behavior is intentional setting behavior covered by tests, so it is not included as a defect.
Source: HelpScout #3424946418
Generated by bug-report-triage (ID: bug-report-triage_6a87087cc5e402.90677248)
- 主要语言
- PHP
- 星标
- 73
- 派生
- 14
- 平均合并
- 2 天 13 小时
- 30 天内合并 PR
- 16
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Codeinwp/optimole-wp 的其他 Issue
-
bug-report bug-report-triage crash-report
难度 4/5 3-5 天 新手友好度 65/100
Codeinwp/optimole-wp#1162 ·
维护者通常 1 天内回复
-
customer report feature-request-triage
难度 3/5 1-2 天 新手友好度 65/100
Codeinwp/optimole-wp#1161 ·
维护者通常 1 天内回复
-
bug-report bug-report-triage customer report regression
难度 4/5 3-5 天 新手友好度 56/100
Codeinwp/optimole-wp#1159 ·
维护者通常 1 天内回复
-
customer report feature-request-triage
难度 3/5 1-2 天 新手友好度 55/100
Codeinwp/optimole-wp#1151 ·
维护者通常 1 天内回复
-
bug-report bug-report-triage crash-report
难度 4/5 3-5 天 新手友好度 55/100
Codeinwp/optimole-wp#1139 ·
维护者通常 1 天内回复
查看 Codeinwp/optimole-wp 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
Automattic/static-site-importer#1879 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
521xueweihan/HelloGitHub#3790 ·
-
Bug (unconfirmed) Good first issue 1️⃣ help wanted UI :art:
难度 2/5 1-3 小时 新手友好度 70/100
FreshRSS/FreshRSS#9360 · 2 条评论 ·
维护者通常 1 天内回复