Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Browser-validate the account-claim flow end-to-end

未关闭
#48 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
68/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
冷清
技术栈
playwright, typescript

调研方向

首先从此分支或合并后的 main 运行开发服务器,然后按照 issue 中描述的两种 GitHub 登录场景进行操作。使用 PR #46 中现有的账号认领界面,并在多候选人的情况下根据需要准备两条 people/*.toml 记录。单候选人的详细信息和 matchedVia 值正确,并且选择一张多候选人卡片只认领该人员,即表示完成。

由索引模型根据 Issue 内容生成。

描述

Context

The account-claim plan (PR #46) covers all paths via unit + integration tests against the in-process Fastify instance. Two validation criteria depend on the running browser experience and were not flipped at merge:

  • OAuth callback with candidates → claim screen renders the candidate(s) with the right info
  • Multi-candidate picker works; selecting one claims it; others remain unclaimed

The implementation is complete; this is purely a manual / playwright verification gap. The parent-repo dev server was busy during the implementation window so I couldn't drive a real GitHub OAuth flow through the new screens without disrupting other agents.

Verification

Run dev in this branch (or a checked-out post-merge main) and:

  1. Sign in via GitHub against a laddr-era email that matches a single legacy Person. Confirm the claim screen renders one card with matchedVia: email, fullName, slug, and member count.
  2. Repeat against a GH identity whose gh.login and email both match different legacy Persons (multi-candidate). Confirm the picker shows both cards; select one; confirm only that Person gets the GH identity and the other stays unclaimed.

Notes: a quick way to seed the multi-candidate path locally is to add two people/*.toml records with distinct slugs and email-match one to your real primary GH email, and have the GH login field equal the other slug.

主要语言
TypeScript
星标
1
派生
1
平均合并
11 分钟
30 天内合并 PR
22

环境准备

我们还没有检查这个项目的环境配置文件。先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

CodeForPhilly/codeforphilly-ng 的其他 Issue

查看 CodeForPhilly/codeforphilly-ng 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。