arch: IIncidentSession/IUiDispatcher/ITrustStore live in LageBuch.Sync; collapse the 5-file-per-operation session ceremony
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with the architecture review and inspect src/LageBuch.Sync/IIncidentSession.cs, LocalIncidentSession, RemoteIncidentSession, SyncCommand, and CommandApplier; the issue names no file paths for the latter four. Trace how view-models and the host apply commands, then assess the proposed interface move and session consolidation. Done means the session abstractions are owned by AppLogic or a contracts project and the local/remote operation surface is consolidated as described.
由索引模型根据 Issue 内容生成。
描述
From the 2026-09-09 architecture review of main (35d86e1). Related: the "Local/Remote session lockstep" item still open in #167.
IIncidentSession (src/LageBuch.Sync/IIncidentSession.cs:22), the application layer's primary port that every view-model drives, lives in LageBuch.Sync together with IUiDispatcher and ITrustStore. AppLogic therefore depends on the sync assembly for its core abstraction, and LocalIncidentSession (in AppLogic) implements an interface owned by Sync.
Adding one domain operation today touches five files: the interface, the LocalIncidentSession forwarder, the RemoteIncidentSession forwarder, a SyncCommand record and a CommandApplier case.
Proposal
- Move
IIncidentSession,IUiDispatcherandITrustStoreto AppLogic (or aLageBuch.Contractsproject); Sync implements them. - Collapse the session surface: let
LocalIncidentSessionapplySyncCommands throughCommandApplierexactly as the host does, so the interface becomesApply(SyncCommand)plus the three file operations and the lifecycle members. View-models then construct commands, and the local/remote split is one method instead of ~40.
- 主要语言
- C#
- 星标
- 1
- 派生
- 3
- 平均合并
- 4 小时 15 分钟
- 30 天内合并 PR
- 181
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
CodeForFire/lagebuch 的其他 Issue
-
Stammdaten: in the Checkliste editor the PFLICHT header is not aligned with its column可能已有人在做 @Saad-elnagar 于 2 天前认领。 未关闭bug ux
难度 2/5 1-3 小时 新手友好度 78/100
CodeForFire/lagebuch#714 · 1 条评论 ·
维护者通常 1 天内回复
-
Stammdaten: on a phone the Fahrzeuge editor squeezes Wache and Funkrufname to nothing可能已有人在做 @Saad-elnagar 于 2 天前认领。 未关闭bug ux
难度 2/5 1-3 小时 新手友好度 75/100
CodeForFire/lagebuch#713 · 1 条评论 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 62/100
CodeForFire/lagebuch#405 ·
维护者通常 1 天内回复
-
documentation good first issue
难度 2/5 1-3 小时 新手友好度 88/100
CodeForFire/lagebuch#349 ·
维护者通常 1 天内回复
-
documentation good first issue
难度 2/5 1-3 小时 新手友好度 88/100
CodeForFire/lagebuch#348 ·
维护者通常 1 天内回复
查看 CodeForFire/lagebuch 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
Nimblesite/SharpLsp#468 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
elastic/ecs-dotnet#575 ·
-
alerts bug effort:S P2
难度 2/5 1-3 小时 新手友好度 76/100
nightscout/nocturne#2511 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 2 天内回复
-
Crash in v3.00未关闭
难度 2/5 1-3 小时 新手友好度 62/100
arkane-systems/mousejiggler#140 ·