Shutting down removes comments from config.yml

未关闭
  • 哪里不对？
#76 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
java
领域
backend

调研方向

The issue identifies Warehouse.saveConfig and the shipped config.yml; start by locating that method and tracing what calls it during startup and shutdown. Check where default stores are set and saved, then verify that starting and stopping the server leaves config.yml unchanged.

由索引模型根据 Issue 内容生成。

描述

bug

Problem

Every clean shutdown rewrites config.yml and removes its comments, including the shipped notes about default stores and custom messages. Warehouse.saveConfig saves the config with a YAML loader that doesn't keep comments.

Confirmed by loading and saving the shipped config.yml: the file had comments before and none after.

Enabling comments in the loader won't keep commented-out example lines, because those aren't attached to any setting.

Scope

  • Only write config.yml when something changed it, such as setting a default store. Better still, move runtime values like default stores into store data, so the plugin never rewrites the admin's file.

Done when

  • Starting and stopping the server leaves config.yml unchanged.
主要语言
Java
星标
1
派生
0
平均合并
2 小时 35 分钟
30 天内合并 PR
14

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

BrendonButler/Shops 的其他 Issue

查看 BrendonButler/Shops 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。