http_client docstring does not say that timeout, verify and proxies only configure the default session
评估
- 难度
- 1/5
- 预计耗时
- 1 小时以内
- 新手友好度
- 25/100
- Issue 类型
- 文档
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- python
调研方向
Read the http_client paragraph in msal/application.py at lines 496–502, then compare it with the timeout, verify and proxies parameter notes at lines 508, 513 and 518. Add one sentence pointing readers to those parameters, and check that the paragraph makes clear they configure only the default session. A linked open pull request already addresses this issue.
由索引模型根据 Issue 内容生成。
描述
The http_client paragraph of ClientApplication.__init__ (msal/application.py:496-502 on dev) explains retries but says nothing about timeout, verify and proxies. Those three parameters each carry "This does not apply if you have chosen to pass your own Http client" (lines 508, 513, 518), so the information exists, but only if you read those three entries; someone reading the http_client docs to decide whether to pass one does not see it.
The behaviour itself is as documented: timeout is applied with functools.partial on the session MSAL builds (application.py:702-713) and a custom client is wrapped in ThrottledHttpClient untouched. Checked on 1.38.0 with a recording fake client: its request receives no timeout kwarg, while the default session's request is a partial with timeout=5.
Proposal: one sentence in the http_client paragraph pointing at the three parameters. PR follows.
- 主要语言
- Python
- 星标
- 971
- 派生
- 223
- 平均合并
- 13 小时 48 分钟
- 30 天内合并 PR
- 2
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
AzureAD/microsoft-authentication-library-for-python 的其他 Issue
-
needs attention untriaged
难度 4/5 3-5 天 新手友好度 48/100
-
AzureSDK bug P1
难度 4/5 3-5 天 新手友好度 48/100
-
[Bug] The built-in retry never retries the token POST: HTTPAdapter(max_retries=1) keeps urllib3's default allowed_methods可能已有人在做 @HardMax71 于 45 天前认领。 未关闭bug untriaged
难度 2/5 1-3 小时 新手友好度 35/100
AzureAD/microsoft-authentication-library-for-python#957 · 3 条评论 ·
-
public-client untriaged
难度 5/5 一周以上 新手友好度 25/100
-
[Bug] Interactive auth callback hangs forever when an idle connection reaches AuthCodeReceiver first可能已有人在做 @Thanatos9404 于 4 天前认领。 未关闭bug public-client
难度 4/5 1-2 天 新手友好度 48/100
AzureAD/microsoft-authentication-library-for-python#950 · 2 条评论 · 3 个 reaction ·
查看 AzureAD/microsoft-authentication-library-for-python 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
docling-project/docling-mcp#147 ·
-
难度 2/5 1-3 小时 新手友好度 80/100
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 76/100
autowarefoundation/autoware_carla_scenario#405 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
mohitmishra786/readprism#322 ·
维护者通常 1 天内回复