Tool endpoints use engine credentials for every caller instead of the per-user OBO branch
@DCMattyG 已经在做这个了。
开始于 2026年9月22日。
评估
这个 Issue 还没有评估数据。
描述
Summary
The three user-facing tool endpoints always query Azure with the engine's own credentials regardless of who is calling, while every equivalent routed endpoint correctly branches between engine credentials (administrators) and the caller's on-behalf-of credentials (everyone else). The result contradicts the documented authorization model, in which non-admin users only see resources they already have access to.
Observed
Line references are against current main (12e41f4).
engine/app/routers/tool.py passes a hardcoded True as the admin argument:
nextAvailableSubnet—arg_query(authorization, True, argquery.VNET)(tool.py:73)nextAvailableVNet—get_network(authorization, True)(tool.py:162)cidrCheck—arg_query(authorization, True, argquery.NET_BASIC)(tool.py:239)
In engine/app/routers/common/helper.py (lines 277-311), admin=True selects get_client_credentials() — the engine app registration, which the deployment grants Reader at the management group (tenant root by default). admin=False builds an OnBehalfOfCredential from the caller's token, so the caller sees only what their own Azure RBAC permits.
The same defect appears a second time through a positional-binding bug: get_network's second positional parameter is tenant_id, so get_network(authorization, True) binds tenant_id=True and leaves admin at its default — an unresolved Depends(get_admin) marker, which is truthy — again selecting engine credentials. This shape is present on the reservation-create path (~line 2956) and the spaces-utilization path in engine/app/routers/space.py.
For contrast, the routed endpoints do this correctly: get_vnet in engine/app/routers/azure.py declares admin: str = Depends(get_admin) and passes the resolved flag through to arg_query.
Expected vs actual
docs/how-to/README.md states the model:
It uses your existing Azure AD credentials to authenticate you and leverages your existing Azure RBAC permissions to authorize what information is visible from within the IPAM tool.
Once at least one IPAM administrator is set, non-admin users will only see resources in IPAM they already have access to from the Azure Portal.
Actual: a non-admin tenant member holding no Azure RBAC on any subscription can call the three tool endpoints and receive the engine's Reader-level view of the management group.
Repro sketch
- Deploy with at least one IPAM administrator configured (so the documented default-open bootstrap is closed).
- Sign in as a second tenant member holding no Azure RBAC on any subscription.
POST /api/tools/cidrCheckwith{"cidr": "10.0.0.0/8"}— returns 200 with vNets from subscriptions the caller cannot read: name, id, resource_group, subscription_id, address prefixes.- Control:
GET /api/azure/vnetsfor the same caller returns the caller's own (empty) view, since that route resolves the admin flag. The differential between the two responses is the issue.
nextAvailableSubnet additionally acts as an existence oracle for any named vNet id (400 "Virtual Network not found" vs 200) and discloses its vnet_name / resource_group / subscription_id; iterating size probes maps a target vNet's subnet layout.
Suggested fix
Resolve the admin flag on the three tool handlers (declare admin: str = Depends(get_admin) and pass it through), mirroring azure.py. At the get_network call sites, pass admin by keyword — the current positional True also corrupts tenant_id. The same hardcoded True is still present on the ipam-3.7.0 branch of #377, so the release PR does not currently cover this.
- 主要语言
- JavaScript
- 星标
- 326
- 派生
- 111
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
Azure/ipam 的其他 Issue
-
nextAvailableVNet fails when using multiple blocks and smallest_cidr option true if no IP range is available in first block可能已有人在做 @DCMattyG 于 65 天前认领。 未关闭bug
-
Overlap in CIDR可能已有人在做 @DCMattyG 于 223 天前认领。 未关闭bug
-
Standalone NICs not listed in Endpoint node可能已有人在做 @DCMattyG 于 310 天前认领。 未关闭bug
-
Planner will not load可能已有人在做 @DCMattyG 于 372 天前认领。 未关闭bug
-
Error fetching available IP Block networks可能已有人在做 @DCMattyG 于 496 天前认领。 未关闭bug
相似的 Issue
-
ci-install-db-tools stall-case tests flake: stalled apt-get can be killed before it logs its call未关闭effort:low model:light plan planner:opus-5-5 tests
难度 2/5 1-3 小时 新手友好度 86/100
维护者通常 1 天内回复
-
Bug 🐞
难度 2/5 1-3 小时 新手友好度 72/100
mozilla-mobile/firefox-ios#35986 ·
维护者通常 1 天内回复
-
component:sight
难度 2/5 1-3 小时 新手友好度 78/100
agentic-os-org/ANOLISA#6738 · 2 条评论 ·
维护者通常 1 天内回复
-
bug Durable Agents Observability (AI Telemetry) status: needs triage
难度 2/5 1-3 小时 新手友好度 82/100
mastra-ai/mastra#26470 · 1 条评论 ·
维护者通常 1 天内回复
-
feature/cohorts feature/feature-flags team/feature-flags
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复