[BUG] API's with revisions are not being set to current.
还没有人认领这个 Issue。
评估
调研方向
从 tools/code/publisher/Api.cs 第 369 行附近开始,跟踪 CorrectApimRevisionNumber,将其修订版本检查与 API 的 apiInformation.json 中的 isCurrent 值进行比较。重现所述的 Azure APIM 提取和发布流程,然后验证工件中标记为当前的修订版本在部署后仍然是当前版本。
由索引模型根据 Issue 内容生成。
描述
Release version
6.0.1.1
Describe the bug
The publishing of our APIM artifacts is failing once there's a reference to an API operation that only exists in the parent APIs second revision, even though the second revision should be the current revision. Looking at the APIs in Azure, I see that the first revision is set as current even though the APIs apiInformation.json file has it's isCurrent property set to true.
From what I can tell, looking at the code, the isCurrent value is being nulled out of the API Dto object to prevent occasional failures.
This causes the API to be initially deployed with out the isCurrent property set, defaulting to revision 1 as current.
I then noticed that there's a process in place to "correct" the revision number: CorrectApimRevisionNumber.
But, reviewing that code, I think I found a small bug preventing that process from correcting the revision numbers of revisioned APIs.
I could be wrong, but it appears that this would skip all revisioned APIs when assessing them for correction.
To test this, I cloned the repo and updated line 369 to:
if (ApiName.IsNotRevisioned(name))
After that, I ran it locally and it published successfully.
Expected behavior
I expect API revisions to be set correctly in accordance to the API's apiInformation.json file.
Actual behavior
Revisioned APIs do not have the correct revision set to current after deployment, causing failures when anything in the now non-current API is referenced.
Reproduction Steps
In a new APIM instance:
- Create an API with a single operation.
- Revision the API.
- Create another operation in that new revision.
- Set the second revision as current (
Make current). - Extract the APIM instance.
- Delete all APIs or create another new APIM instance.
- Publish the extracted artifacts to the cleaned or new APIM instance.
You should see that revision 1 is incorrectly set as current.
- 主要语言
- C#
- 星标
- 448
- 派生
- 247
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Azure/apiops 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 3/5 1-2 天 新手友好度 70/100
-
难度 4/5 3-5 天 新手友好度 55/100
-
难度 3/5 1-2 天 新手友好度 45/100
-
难度 5/5 一周以上 新手友好度 35/100
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
nightscout/nocturne#1425 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
RayWangQvQ/BiliBiliToolPro#1137 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 70/100