ACF block's saved data (repeater sub-fields) silently blanked on normal Update — block `mode` flips to "preview" even without touching preview/expanded-editor UI
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 42/100
调研方向
首先比较 acf/ajax/fetch-block 周围的修订内容 diff 和 Apache access-log 时间,以及 wp-json/wp/v2/pages 保存请求的时间。阅读 issue #1025,了解相关的 isFetchingBlock 行为,并跟踪 block 属性在序列化之前是如何协调的。完成的标准是复现该 regression,或建立一个 regression test,防止 preview/loading 状态在 Update 期间覆盖 repeater 值。
由索引模型根据 Issue 内容生成。
描述
TITLE:
ACF block's saved data (repeater sub-fields) silently blanked on normal Update — block mode flips to "preview" even without touching preview/expanded-editor UI
BODY:
Describe the bug
A block registered via acf_register_block_type() (no acf_block_version set, so default V2/mode: edit behavior) containing a repeater field can have its mode attribute flip from "edit" to "preview" on a normal Save/Update click — with no one touching the block's preview/expanded-editor toggle. When this happens, every repeater sub-field value (e.g. image) is serialized as an empty string in the saved post_content, and the front end renders the block's static registration-time preview instead of the real content. This has happened twice in production for us in the last 24 hours, both times on ordinary edits (removing/updating repeater rows) via the standard sidebar "Block" panel — never via the pencil/expand icon or any preview toggle.
To Reproduce
We were not able to build a deterministic, isolated repro — this is what we reconstructed from two real production incidents via WordPress revision history and Apache access logs:
- Register a block via
acf_register_block_type()with'mode' => 'edit'and a repeater sub-field (e.g. image + text), noacf_block_versionset. - Open a page containing the block in the block editor. Click the block (not the pencil/expand icon) and edit a repeater row in the standard sidebar "Block" panel — the panel shows correct, real data.
- Click Update.
- Compare the resulting revision to the one before it: in both of our incidents, every block on the page had
"mode":"edit"flip to"mode":"preview", and every repeater image sub-field flipped from a real attachment ID to"". - In both cases, saving again (Update) a second time, ~15–50 seconds later, produced a correct revision (
mode:"edit", real values restored) — so the underlying field data was never actually lost, just the specific save was corrupted.
Apache access logs around the bad save show a burst of POST /wp-admin/admin-ajax.php requests (consistent with acf/ajax/fetch-block) in the 10–30 seconds immediately before the POST /wp-json/wp/v2/pages/{id} save request that produced the bad revision — in both incidents. We were not able to capture the exact in-browser request bodies live (both incidents were caught after the fact from logs), but the timing strongly suggests a race between an in-flight block preview/fetch and the block's attributes being read for serialization at save time — similar in spirit to the isFetchingBlock timing issues described in #1025, but manifesting as silent data loss on a normal save rather than a stuck UI.
Expected behavior
Clicking Update should never serialize a block's in-progress/loading state (mode: preview, blank repeater values) over real, already-saved data — either by not allowing the save to proceed while a block's data is still resolving, or by never letting a block's committed attributes regress to a default/blank state once real values have loaded.
Version Information
- WordPress: 7.1
- Advanced Custom Fields PRO: 6.8.8
- PHP: 8.3.6
- Block registered via
acf_register_block_type()(PHP array registration, notblock.json),'mode' => 'edit', noacf_block_versionset.
Additional context
This may be related to two other things we found while investigating:
- A separate, purely cosmetic issue: without
acf_block_versionset, the editor canvas shows the block's registeredexample/preview image instead of a live render whenever the block isn't the actively-selected block. Settingacf_block_version: 3fixes that, but on our repeater blocks it breaks the V3 "expanded editor" panel instead — every repeater sub-field renders blank in that panel's form (real data, correct on the server side, just not applied to the panel's inputs), which is why we reverted to the V2 default and are hitting the bug described above instead. - #1025 (filed today) describes the Expanded Editor becoming unresponsive during an in-flight block preview re-fetch (
isFetchingBlock), which reads to us like the same underlying fetch/attribute-reconciliation timing area of the codebase, just a different symptom (stuck UI there, silently-blanked saved data here).
Happy to provide the exact revision content diffs (before/after JSON) and access log excerpts from our two incidents if useful — redacted to remove real customer data.
- 主要语言
- PHP
- 星标
- 947
- 派生
- 198
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
AdvancedCustomFields/acf 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
AdvancedCustomFields/acf#1056 ·
-
PHP 8.5: "Using null as an array offset" deprecation in ACF_Data::is() when rendering a block with empty data (local-meta.php is_request)可能已有人在做 @faisalahammad 于 30 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
AdvancedCustomFields/acf#1044 ·
-
is_preview was called incorrectly notice on every early get_field() since 6.8.10 (acf_revisions::acf_validate_post_id)可能已有人在做 @faisalahammad 于 30 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
AdvancedCustomFields/acf#1041 · 1 条评论 ·
-
True / False ACF control bug on RTL layouts可能已有人在做 @elicohenator 于 53 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 86/100
AdvancedCustomFields/acf#1038 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
AdvancedCustomFields/acf#1034 · 3 条评论 ·
查看 AdvancedCustomFields/acf 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
-
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 3 天内回复
-
难度 1/5 1 小时以内 新手友好度 91/100
benjaminkott/bootstrap_package#1675 ·
-
sync-en
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复
-
[Sync EN] Formatting improvements to "Large Objects (LOBs)" docs (#6056)可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭sync-en
难度 1/5 1 小时以内 新手友好度 74/100
维护者通常 1 天内回复