Finalize ACES 2 FixedFunctions and remove warnings
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- cpp
调研方向
检查 ACES fixed-function definitions 以及 YAML reader 和 writer，然后检查 Config_tests.cpp 中的 "experimental"，以及 OpenColorTypes.h 中的 fixed-function descriptions。确定最终的 channel ordering、normalization 和 decomposition behavior；完成意味着 functions 已最终确定、warnings 已移除，并且 experimental markers 及相关的 test expectations 已清理完毕。
由索引模型根据 Issue 内容生成。
描述
When ACES 2 was implemented, there was some uncertainty in how to decompose the overall Output Transforms into FixedFunctions, and so the YAML reader and writer issue warnings when any of these are used:
FIXED_FUNCTION_ACES_OUTPUT_TRANSFORM_20
FIXED_FUNCTION_ACES_RGB_TO_JMH_20
FIXED_FUNCTION_ACES_TONESCALE_COMPRESS_20
FIXED_FUNCTION_ACES_GAMUT_COMPRESS_20
At this point, we should try to finalize what the fixed functions are and remove the warnings.
I like having a function to convert to JMh, but there are two things I find inconvenient about the current one:
- The results are in the hundreds (e.g., J goes up above 800, h goes up to 360) and this makes it inconvenient to use in other tools that would prefer more of a 0 to roughly 1 normalization.
- The more conventional channel layout is for hue to be first and lightness to be last. For example, the existing conversions to HSV and HSY use that channel layout.
Currently, in order to use the existing RGB_TO_JMH with the GradingHueCurveTransform, I need to put a matrix on either side to rescale and reorder the channels. My proposal would be to create a new function that is ordered hMJ and has h divided by 360 and J divided by roughly 500.
Similarly, my only concern about the others is whether the inputs/outputs are normalized in a way that is convenient.
As we are currently developing LMTs that may work in JMh, it would be helpful if the optimizer was able to decompose an ACES_OUTPUT_TRANFORM into one or more fixed functions that expects JMh (from an LMT) as input so that a pair of RGB_TO_JMH and JMH_to_RGB could be dropped. Currently, is it possible to replace an ACES_OUTPUT_TRANSFORM with RGB_to_JMH + TONESCALE_COMPRESS + GAMUT_COMPRESS + JMH_to_RGB?
Tagging @KevinJW and @remia for input.
Note: When implementing this, search Config_tests.cpp for "experimental" and clean up accordingly. Likewise remove "experimental" from OpenColorTypes.h fixed function descriptions.
- 主要语言
- C++
- 星标
- 2.1k
- 派生
- 502
- 平均合并
- 6 天 3 小时
- 30 天内合并 PR
- 6
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
AcademySoftwareFoundation/OpenColorIO 的其他 Issue
-
Inconsistent run-time library usage for locale handling breaks GPU code generation on some systems.未关闭
难度 2/5 1-3 小时 新手友好度 86/100
AcademySoftwareFoundation/OpenColorIO#2351 · 2 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
AcademySoftwareFoundation/OpenColorIO#2340 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
AcademySoftwareFoundation/OpenColorIO#2329 ·
维护者通常 1 天内回复
-
Build failure on GCC/MinGW (MXE): std::ifstream constructor mismatch with Platform::filenameToUTF()未关闭
难度 2/5 1-3 小时 新手友好度 78/100
AcademySoftwareFoundation/OpenColorIO#2283 ·
维护者通常 1 天内回复
-
Documentation
难度 1/5 1 小时以内 新手友好度 72/100
AcademySoftwareFoundation/OpenColorIO#2280 · 1 条评论 ·
维护者通常 1 天内回复
查看 AcademySoftwareFoundation/OpenColorIO 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
scp-fs2open/fs2open.github.com#7914 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 74/100
eclipse-score/inc_someip_gateway#356 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
HarperFast/rocksdb-js#945 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复