[BUG]: chunk_rag_data crashes with ValueError when perspective is a dict, silently dropping RAG vector storage
评估
调研方向
从 backend/app/modules/vector_store/chunk_rag_data.py 开始,该文件中 chunk_rag_data() 在第 61 行附近使用 hasattr() 校验 data['perspective']。运行 issue 中的复现片段以确认 ValueError,并查看 langgraph_nodes/store_and_send.py,了解 dict 如何传入此函数。完成标准是:同时包含两个键的 dict 输入能够被分块,缺少键时抛出描述清晰的错误,对象输入仍然可用,并且单元测试覆盖每种情况。
由索引模型根据 Issue 内容生成。
描述
Fix Perspective Validation for Dictionary Inputs in chunk_rag_data
Bug Description
In backend/app/modules/vector_store/chunk_rag_data.py, the chunk_rag_data() function validates the perspective data using hasattr() on data["perspective"].
However, when perspective is provided as a standard Python dictionary, as can happen when deserializing LangGraph pipeline state or JSON payloads, hasattr() returns False for dictionary keys. This causes the function to raise a ValueError even when all required fields are present.
The current validation logic is:
perspective_obj = data["perspective"]
if not (
hasattr(perspective_obj, "perspective")
and hasattr(perspective_obj, "reasoning")
):
raise ValueError("Perspective object missing required fields")
For dictionary inputs, the required fields must be checked using dictionary key access or an equivalent mapping-aware validation approach.
Steps to Reproduce
- Open a terminal in the
backend/directory with the project virtual environment activated. - Run the following Python snippet:
from app.modules.vector_store.chunk_rag_data import chunk_rag_data
sample_state = {
"cleaned_text": "Sample text for chunking and article ID generation.",
"perspective": {
"perspective": "Synthesized counter perspective narrative.",
"reasoning": "Underlying tradeoffs and evidentiary counter-arguments."
},
"facts": [
{
"original_claim": "Claim 1",
"verdict": "Verified",
"explanation": "Evidence description",
"source_link": "https://example.com"
}
]
}
chunk_rag_data(sample_state)
Actual Behavior
The function raises a ValueError even though the perspective dictionary contains both required fields:
ValueError: Perspective object missing required fields
The error is logged by chunk_rag_data() and prevents the supplied data from being processed successfully.
Expected Behavior
- The function should accept perspective data represented as a standard dictionary when the required fields are present.
- Validation should correctly check for the
perspectiveandreasoningkeys in dictionary inputs. - Missing or invalid required fields should produce a descriptive validation error.
- Existing behavior for supported perspective object types should be preserved.
- Valid input should proceed through the normal chunking process.
Logs and Screenshots
[ERROR] [app.modules.vector_store.chunk_rag_data]: Failed to chunk the data: Perspective object missing required fields
Traceback (most recent call last):
File "backend/app/modules/vector_store/chunk_rag_data.py", line 61, in chunk_rag_data
raise ValueError("Perspective object missing required fields")
ValueError: Perspective object missing required fields
Environment Details
- OS: Windows / Linux / macOS
- Python: 3.13
- File:
backend/app/modules/vector_store/chunk_rag_data.py - Related module:
backend/app/modules/langgraph_nodes/store_and_send.py
Impact
Severity: Medium — Valid dictionary-based pipeline state is rejected during chunking, potentially disrupting downstream vector storage and retrieval workflows.
Proposed Solution
- Replace the
hasattr()-only validation with mapping-aware validation for dictionary inputs. - Check that both
perspectiveandreasoningare present and contain valid values before processing. - Preserve compatibility with existing supported object-based inputs, if required.
- Add unit tests covering valid dictionaries, missing fields, invalid values, and supported object inputs.
Code of Conduct
- I have joined the [Discord server](https://discord.gg/hjUhu33uAn) and will post updates there.
- I have searched existing issues to avoid duplicates.
- 主要语言
- TypeScript
- 星标
- 58
- 派生
- 90
- 平均合并
- 11 小时 51 分钟
- 30 天内合并 PR
- 3
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
AOSSIE-Org/Perspective 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 83/100
AOSSIE-Org/Perspective#191 ·
-
难度 2/5 1-3 小时 新手友好度 85/100
AOSSIE-Org/Perspective#190 ·
-
[BUG]: Missing input validation in URlRequest and ChatQuery causes 500 crashes and wasteful scraper execution可能已有人在做 @agarwalpranav0711 于 25 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
AOSSIE-Org/Perspective#178 ·
-
[BUG]: Scraper passes headers as query params in requests.get (User-Agent never sent)可能已有人在做 @Th-Shivam 于 50 天前认领。 未关闭bug
难度 1/5 1 小时以内 新手友好度 92/100
AOSSIE-Org/Perspective#161 · 1 条评论 ·
-
docs: frontend/README.md is the default create-next-app boilerplate可能已有人在做 @Th-Shivam 于 51 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 85/100
AOSSIE-Org/Perspective#159 · 1 条评论 ·
查看 AOSSIE-Org/Perspective 的全部 Issue
相似的 Issue
-
documentation lens:human needs-triage
难度 2/5 1-3 小时 新手友好度 73/100
thebristolsound/birdbrain#2246 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 78/100
维护者通常 1 天内回复
-
bug ready-for-human
难度 2/5 1-3 小时 新手友好度 72/100
BoardGamesEmpire/board-games-empire-backend#1452 · 1 条评论 ·
维护者通常 1 天内回复
-
good first issue stretch
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复