[Bug]: Renaming a library to an existing name merges the two libraries
還沒有人認領這個 Issue。
評估
研究方向
Start at src/api/settings.rs:306 in updateLibrary, where the rename is committed before config.update_library runs. Read Config::validate to see where the duplicate-name check lives, then reorder or pre-validate so the name is checked against the other libraries before any database write. Done means renaming A to B returns the "two libraries are called" error with no items, tracks, stars, ratings or permission lists relabeled; the issue notes this was found by reading code and not yet reproduced, so build a two-library case first.
由索引模型根據 Issue 內容生成。
描述
[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.
Version
0.40.0 (feat/desktop, 017a837b)
Area
Config
What happened?
updateLibrary renames the library in the database and commits (src/api/settings.rs:306) before calling config.update_library, which is where duplicate names are rejected (Config::validate). Renaming A to an existing B relabels all of A's items, skipped files, tracks, albums, artists, stars and ratings as B, then returns an error. The config still lists both libraries, and A's titles now show up in B. Permission lists are renamed only after the commit, so they're left pointing at A.
Steps to reproduce
- Have two libraries, A and B.
- Rename A to B in settings: you get "two libraries are called "B"".
- B now contains A's titles and A is empty.
Expected behavior
The rename is refused before anything in the database changes.
Suggested fix
Validate the new name against the other libraries first (or apply the config change first and only rename in the DB once it succeeded).
- 主要語言
- TypeScript
- 星號
- 4
- 分支
- 1
- 平均合併
- 4 小時 49 分鐘
- 30 天內合併 PR
- 5
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 沒有貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
tinystream-dev/tinystream 的其他 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 82/100
tinystream-dev/tinystream#132 ·
-
bug
難度 2/5 1-3 小時 新手友好度 82/100
tinystream-dev/tinystream#131 ·
-
bug
難度 1/5 1 小時以內 新手友好度 88/100
tinystream-dev/tinystream#129 ·
-
bug
難度 2/5 1-3 小時 新手友好度 76/100
tinystream-dev/tinystream#128 ·
-
bug
難度 2/5 1-3 小時 新手友好度 78/100
tinystream-dev/tinystream#124 ·
查看 tinystream-dev/tinystream 的全部 Issue
相似的 Issue
-
難度 1/5 1 小時以內 新手友好度 86/100
sandbox-quantum/switch#2163 ·
維護者通常 1 天內回覆
-
automated issue report
難度 1/5 1 小時以內 新手友好度 78/100
維護者通常 1 天內回覆
-
area/dashboard kind/bug QA/dev-automation
難度 1/5 1 小時以內 新手友好度 75/100
維護者通常 1 天內回覆
-
bug pydanty:is-working
難度 2/5 1-3 小時 新手友好度 82/100
pydantic/pydantic-ai#13939 ·
維護者通常 1 天內回覆
-
self-host
難度 2/5 1-3 小時 新手友好度 70/100
funmusicplace/mirlo#2625 ·
維護者通常 1 天內回覆