[Enhancement]: Speed up elasticsearch module CI (22 min vs ~1 min for other modules)
維護者通常 2 天內回覆
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 48/100
- Issue 類型
- 功能
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- docker, github-actions, java
- 領域
- ci-cd, devops, testing-qa
研究方向
從 ElasticsearchContainerTest 和 KibanaContainerTest 類別,以及執行 :testcontainers-elasticsearch:check 的 CI 模組矩陣開始。在選擇拆分 job、減少測試或重複使用容器之前,測量目前各類別的耗時,並檢查 setup-build 映像檔的清理情況。完成的標準是在保留所列涵蓋範圍和現有單元測試的同時,記錄一項 CI 速度改進。
由索引模型根據 Issue 內容生成。
描述
Module
Elasticsearch
Proposal
Summary
:testcontainers-elasticsearch:check is the CI critical path. On main (GitHub Actions run 34364782867, 9 Sep 2026) that job took 22 min 26 s (Gradle step alone: 21 min 50 s). Typical sibling module jobs finish in ~1–2 minutes.
The workflow is core → all modules in parallel → examples. Examples need the entire module matrix, so this one job delays the whole pipeline by ~20 minutes on every PR, even when PostgreSQL or Kafka finished in ~90 s.
This is a proposal only — no code in this issue.
Why it is slow
33 @Test methods, almost all sequential, each using try-with-resources (no shared @Container, no maxParallelForks). Elasticsearch takes ~30–60 s to reach yellow; Kibana ~40–90 s. We pay that on every method.
| Cost | Count | Detail |
|---|---|---|
| Elasticsearch starts | ~28 | 16 in ElasticsearchContainerTest + 12 from Kibana tests (including one throwaway elasticsearch-certutil container and 2 negative tests that still dependsOn(es)) |
| Kibana starts | 9 | reusesContainerWhenReuseIsEnabled is skipped in CI (testcontainers.reuse.enable=false) |
| Distinct Docker images | 7 | ES 9.5.2 (docker.elastic.co), ES 8.19.20, ES 7.17.29, OSS 7.10.2, ES 9.5.2 (Docker Hub), Kibana 9.5.2, Kibana 9.5.0 |
CI setup-build runs docker image prune -af before tests, so none of those image layers are reused between jobs. Extra images are especially expensive.
Per-test timings below are estimates from test structure (one ES start ≈ 30–60 s, ES+Kibana ≈ 1.5–3 min, plus a cold pull). Individual JUnit XML times were not available from that run.
Proposals (by ROI)
Minutes are job wall clock, not total compute, unless noted.
1. Split the Gradle job in two — ~22 min → ~11–12 min wall clock
Today a single matrix entry :testcontainers-elasticsearch:check runs both test classes in series. CI already parallelizes by module. Two jobs would keep the same coverage and the same compute:
--tests org.testcontainers.elasticsearch.ElasticsearchContainerTest
--tests org.testcontainers.elasticsearch.KibanaContainerTest
Safest change: no tests removed.
2. Drop or nightly five tests / three extra images — ~22 → ~14–16 min
Good candidates to remove from the PR critical path (or move to a scheduled job):
| Test | Why it is low value on every PR | Est. save |
|---|---|---|
clusterHealthIsAtLeastYellowAfterStart |
Wait strategy already waits for yellow/green; also covered by latestStartsWithTlsAndPassword |
~45 s |
v8StartsWithDefaults |
8.x and 9.x share isAtLeastMajorVersion8. This is an 8.x boot canary, not distinct module behaviour — plus a full 8.x image pull |
~1–2 min |
ossImageHasNoXpackEndpoint |
OSS is deprecated. ossImageRejectsPassword already covers isOss without starting a container |
~1–2 min |
v7TransportClientCanQueryClusterHealth |
Transport client was removed in ES 8; getTcpHost() is @Deprecated. Full start for a dead API (docs snippet can stay as a static excerpt) |
~45 s |
externalModeAcceptsOlderKibanaPatchThanElasticsearch |
Elastic product patch compatibility, not Testcontainers logic. Pulls a second Kibana image (9.5.0) | ~2–3 min |
Avoiding the ES 8, OSS, and Kibana 9.5.0 pulls is a large part of the win because of the prune.
latestWorksWithDockerHubImage is similar (second copy of 9.5.2 from Docker Hub). assertCompatibleWith is already tested; a nightly start would be enough.
3. Stop starting Elasticsearch for expected exceptions — ~1.5–2 min
managedModeRejectsWhenOnlyElasticsearchHasExplicitNetwork and managedModeRejectsWhenNetworksDiffer call kibana.start() with dependsOn(es). Elasticsearch reaches yellow, then Kibana throws IllegalStateException.
Extract ensureCorrectNetworkSetupForManagedMode() (or equivalent) to package-private and unit-test it without Docker.
4. Share one default Elasticsearch container — ~2–3 min
latestStartsWithTlsAndPassword, latestDefaultHeapIsTwoGb, and the yellow health check (if kept) use the same default config. A static @Container avoids 2–3 starts.
Do not share once env differs (TLS off, custom heap, custom wait strategy).
5. Smaller test heap, and fixture certs (follow-up)
The module defaults to 2g heap. Tests could use -Xms512m -Xmx512m to start a bit faster and maybe allow maxParallelForks=2 on a 7 GB runner. Flake risk — measure first.
externalModeReachesElasticsearchWithTlsAndServiceToken starts a throwaway ES only to run elasticsearch-certutil. Commit PEMs under src/test/resources (http_ca.crt already exists for another test).
Combined reasonable target
Split CI (1) + drop extra images (2) + negative tests without Docker (3) → about 8–10 min wall clock, without touching 9.x / 7.x / Kibana managed+external happy paths. Heap, forks, and a static container can wait until that lands.
Tests to cheapen (keep coverage, cut cost)
| Test | Today | Suggestion |
|---|---|---|
latestDefaultHeapIsTwoGb |
Extra ES 9 with the same config as the TLS smoke | Merge into latestStartsWithTlsAndPassword |
latestHeapCanBeSetViaJvmOptionsFile |
Extra ES 9 | Keep latestHeapCanBeSetViaEnv only on PRs |
managedModeUsesCustomElasticsearchNetworkAlias |
Full ES + Kibana wait, then greps env | Only needs ELASTICSEARCH_HOSTS; skip /api/status / use a shorter wait |
latestHonorsCustomHttpsWaitStrategy |
Full ES 9 | Keep — regression for configureWaitStrategy() not overwriting waitingFor() |
reusesContainerWhenReuseIsEnabled is already skipped in CI. Keep for local/reuse coverage; cost in CI is 0.
Do not cut
ElasticsearchContainer has two real branches: isAtLeastMajorVersion8 and isOss. 8.x and 9.x share the first; 7.x (and OSS) are the actual divergences. On Kibana, managed vs external and security/TLS on/off are real configure() paths.
Keep:
latestStartsWithTlsAndPassword— 9.x TLS / auth / version / xpack / anonymouslatestCanDisableTls— HTTP when SSL is offlatestRejectsMismatchedCa—withCertPath+ handshake failure- one heap override path (
viaEnv) v7UsesHttpWithoutSecurityByDefault+v7EnablesSecurityWithPassword— 7.x behaves differentlyv7SupportsCustomTlsCertificates—withCertPath+ custom entrypoint (the expensive 7.x test that is actually unique)nonSemanticLatestTagStillStarts—:latestvs the>= 8heuristic- existing unit tests (no container):
ossImageRejectsPassword,managedModeRejectsExplicitElasticsearchUrl,externalModeRejectsConflictingCredentials,rejectsKibanaVersionBelow8,startFailsWhenElasticsearchIsNotConfigured - Kibana happy paths: shared network, ad-hoc network, security off, TLS off, external user/password, external without credentials, external TLS + service token
7.x note
Four 7.17.29 starts today. Useful PR minimum: HTTP without security + withPassword. Keep custom TLS 7.x. Transport client and OSS start can leave the critical path (ossImageRejectsPassword stays).
Happy to hear your feedbacks on it.
cc @pioorg
- 主要語言
- Java
- 星號
- 8.8k
- 分支
- 1.9k
- 平均合併
- 3 天 4 小時
- 30 天內合併 PR
- 9
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 提供 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
testcontainers/testcontainers-java 的其他 Issue
-
[Enhancement]: Document why singleton containers are required under Spring's test context caching可能已有人在做 @zakaullah075 於 72 天前認領。 未關閉type/enhancement
難度 1/5 1 小時以內 新手友好度 85/100
testcontainers/testcontainers-java#11967 · 1 則留言 ·
維護者通常 2 天內回覆
-
[Bug]: Cannot reuse Selenium BrowserWebDriverContainers under Linux可能已有人在做 @kdelay 於 94 天前認領。 未關閉type/bug
難度 2/5 1-3 小時 新手友好度 78/100
testcontainers/testcontainers-java#11941 ·
維護者通常 2 天內回覆
-
[Bug]: DockerDesktopClientProviderStrategy is always applicable可能已有人在做 @seonwooj0810 於 143 天前認領。 未關閉type/bug
難度 2/5 1-3 小時 新手友好度 74/100
testcontainers/testcontainers-java#11829 · 1 則留言 ·
維護者通常 2 天內回覆
-
[Enhancement]: cleanup document after removing junit4 support可能已有人在做 @SJvaca30 於 150 天前認領。 未關閉type/enhancement
難度 2/5 1-3 小時 新手友好度 65/100
testcontainers/testcontainers-java#11578 ·
維護者通常 2 天內回覆
-
[Feature]: Presto Module uses the outdated Docker Image of `ghcr.io/trinodb/presto` and needs to be updated to `prestodb/presto`可能已有人在做 @linghengqian 於 833 天前認領。 未關閉help wanted type/feature
難度 2/5 1-3 小時 新手友好度 68/100
testcontainers/testcontainers-java#8657 · 4 則留言 ·
維護者通常 2 天內回覆
查看 testcontainers/testcontainers-java 的全部 Issue
相似的 Issue
-
agent:working follow-up
難度 2/5 1-3 小時 新手友好度 76/100
Sanne/incus-spawn#1683 · 2 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
checkstyle/checkstyle#22210 ·
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 75/100
521xueweihan/HelloGitHub#4105 ·
-
devops good first issue security
難度 2/5 1-3 小時 新手友好度 68/100
-
難度 2/5 1-3 小時 新手友好度 72/100
asciidoctor/asciidoctorj#1339 ·