BridgeJS: Remove JSException storage boxing once swiftlang/swift#89715 lands
@krodak 已經在處理了。
開始於 2026年6月11日。
評估
這個 Issue 還沒有評估資料。
描述
Tracks removal of the JSException storage boxing introduced in #766.
Context
swiftlang/swift#89320 miscompiles Wasm calls to captureless async throws(JSException) closure values when the typed error exceeds the direct error convention: the thrown error is corrupted across the async unwind, so the rejected Promise receives garbage. JSException (~36 bytes) always took the affected indirect-error path.
#766 works around this at the library level by boxing JSException's stored properties (thrownValue, description, stack) into a private final class, shrinking the struct to a single stored reference so it travels in the direct error convention and the broken path is never taken. The public API is unchanged; the cost is one heap allocation per thrown exception. The original exploration is in https://github.com/PassiveLogic/JavaScriptKit/pull/13.
The codegen-level counterpart for zero-parameter async throwing exports is tracked separately in #761.
What to do once the compiler fix ships
The proper fix is swiftlang/swift#89715 (IRGen: fix async typed throws miscompiles on Wasm). Once it is available in the oldest Swift toolchain JavaScriptKit supports:
- Move
thrownValue,description, andstackback to stored properties onJSExceptionand delete theStorageclass. This is a library-internal layout change only, not a breaking API change. - Keep the async closure reject end-to-end tests as the regression guard that the reject path still works without the boxing.
- 主要語言
- Swift
- 星號
- 986
- 分支
- 76
- 平均合併
- 21 小時 11 分鐘
- 30 天內合併 PR
- 4
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
swiftwasm/JavaScriptKit 的其他 Issue
-
難度 3/5 1-2 天 新手友好度 55/100
swiftwasm/JavaScriptKit#793 ·
-
swiftwasm/JavaScriptKit#785 · 已指派 1 人 ·
-
[SwiftBuild] Preserve duplicate archive members when SwiftBuild expands static archives for linking 未關閉
難度 4/5 3-5 天 新手友好度 48/100
swiftwasm/JavaScriptKit#781 · 3 則留言 ·
-
難度 4/5 3-5 天 新手友好度 25/100
swiftwasm/JavaScriptKit#773 ·
-
swiftwasm/JavaScriptKit#761 · 已指派 1 人 ·
查看 swiftwasm/JavaScriptKit 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 75/100
-
area:general bug P1 security
難度 2/5 1-3 小時 新手友好度 75/100
uttrflow/uttrflow-swift#1333 ·
-
難度 2/5 1-3 小時 新手友好度 75/100
-
難度 2/5 1-3 小時 新手友好度 75/100
maxgoedjen/secretive#840 ·
-
難度 2/5 1-3 小時 新手友好度 88/100
manaflow-ai/cmux#13763 ·