dnd.endSnooze/dnd.info fail with NumberFormatException: next_dnd_end_ts is Integer but should be Long (overflow > Integer.MAX_VALUE)
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
閱讀 issue 中提到的回應類別:DndEndSnoozeResponse、DndInfoResponse 和 DndSetSnoozeResponse。將列出的 epoch 秒欄位及其 getter 和 setter 從 Integer 改為 Long,然後檢查現有回應測試,或新增解析 9999999999 的測試。完成標準是六個欄位在反序列化期間都能保留較大的時間戳。
由索引模型根據 Issue 內容生成。
描述
Summary
dnd.endSnooze (and dnd.info / dnd.setSnooze) fail to deserialize when a DND/snooze timestamp exceeds Integer.MAX_VALUE (2,147,483,647). The response fields are epoch seconds but are typed java.lang.Integer, so any value at or beyond the Year-2038 boundary (2038-01-19T03:14:07Z) overflows. In practice this happens today: when a user has no scheduled DND end, Slack returns "next_dnd_end_ts": 9999999999, which throws.
Affected fields (all epoch seconds, all currently Integer):
DndEndSnoozeResponse.nextDndStartTs,DndEndSnoozeResponse.nextDndEndTsDndInfoResponse.nextDndStartTs,DndInfoResponse.nextDndEndTs,DndInfoResponse.snoozeEndtimeDndSetSnoozeResponse.snoozeEndtime
These should be Long, consistent with the fix already applied in #1520 ("ChannelCreatedEvent created is Integer, but should be Long").
Reproducible in:
The Slack SDK version
com.slack.api:slack-api-client:1.47.0
(Confirmed still present on main: next_dnd_start_ts and next_dnd_end_ts are declared private Integer ... in slack-api-client/src/main/java/com/slack/api/methods/response/dnd/DndEndSnoozeResponse.java.)
Java Runtime version
openjdk version "21.0.7" 2025-04-15 LTS
OpenJDK Runtime Environment Temurin-21.0.7+6 (build 21.0.7+6-LTS)
OS info
macOS 27.2 (Darwin 27.2.0)
Steps to reproduce:
- Call
methods.dndEndSnooze(DndEndSnoozeRequest.builder().build())for a user whose account has no scheduled DND end. - Slack returns a response body containing
"next_dnd_end_ts": 9999999999(value >Integer.MAX_VALUE). - Gson attempts to read it into the
Integer nextDndEndTsfield and throws.
Minimal illustration of the failing parse:
String body = "{\"ok\":true,\"dnd_enabled\":true,\"next_dnd_start_ts\":9999999999,\"next_dnd_end_ts\":9999999999,\"snooze_enabled\":false}";
GsonFactory.createSnakeCase().fromJson(body, DndEndSnoozeResponse.class); // throws
Expected result:
The response deserializes successfully, with the large timestamp preserved (e.g. nextDndEndTs == 9999999999L).
Actual result:
com.google.gson.JsonSyntaxException: java.lang.NumberFormatException: Expected an int but was 9999999999 at line 1 column 90 path $.next_dnd_end_ts
at com.google.gson.internal.bind.TypeAdapters$7.read(TypeAdapters.java:267)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:516)
at com.slack.api.methods.impl.MethodsClientImpl.parseJsonResponseAndRunListeners(MethodsClientImpl.java:4078)
at com.slack.api.methods.impl.MethodsClientImpl.dndEndSnooze(MethodsClientImpl.java:2338)
...
Caused by: java.lang.NumberFormatException: Expected an int but was 9999999999 at line 1 column 90 path $.next_dnd_end_ts
at com.google.gson.stream.JsonReader.nextInt(JsonReader.java:1304)
Suggested fix
Change the affected epoch-seconds fields from Integer to Long (and their getters/setters), matching the precedent in #1520. This also future-proofs normal (non-sentinel) DND timestamps, which will all exceed Integer.MAX_VALUE after 2038-01-19.
- 主要語言
- Java
- 星號
- 602
- 分支
- 241
- 平均合併
- 18 小時 33 分鐘
- 30 天內合併 PR
- 38
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
slackapi/java-slack-sdk 的其他 Issue
-
auto-triage-stale enhancement project:slack-api-model
難度 3/5 半天 新手友好度 75/100
slackapi/java-slack-sdk#1657 · 3 則留言 ·
維護者通常 1 天內回覆
-
Upgrade Jetty可能已有人在做 @skrcode 於 79 天前認領。 未關閉auto-triage-skip dependencies good first issue
難度 4/5 3-5 天 新手友好度 45/100
slackapi/java-slack-sdk#1567 · 4 則留言 ·
維護者通常 1 天內回覆
-
auto-triage-skip discussion enhancement
難度 3/5 1-2 天 新手友好度 35/100
slackapi/java-slack-sdk#1535 · 5 則留言 ·
維護者通常 1 天內回覆
-
auto-triage-skip question untriaged
難度 5/5 一週以上 新手友好度 25/100
slackapi/java-slack-sdk#1528 · 7 則留言 ·
維護者通常 1 天內回覆
-
auto-triage-skip dependencies project:slack-api-client project:slack-app-backend
難度 4/5 3-5 天 新手友好度 48/100
slackapi/java-slack-sdk#1500 · 11 則留言 · 1 個 reaction ·
維護者通常 1 天內回覆
查看 slackapi/java-slack-sdk 的全部 Issue
相似的 Issue
-
status: waiting-for-triage
難度 2/5 1-3 小時 新手友好度 76/100
spring-projects/spring-ai#7427 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 65/100
維護者通常 1 天內回覆
-
Needs: Triage :mag: Platform: Android
難度 2/5 1-3 小時 新手友好度 78/100
react/react-native#60167 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 64/100
tronprotocol/java-tron#7118 ·
維護者通常 1 天內回覆