bsc crashes with `Fatal error: exception Not_found` on `Some(x)` when the type of `x` comes from a transitive dependency
維護者通常 1 天內回覆
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 76/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 領域
- compilers
研究方向
Start in compiler/ml/typeopt.ml at type_cannot_contain_undefined and inspect the Env.find_type lookup, then compare the related code from ReScript 11.1.4 and the call path through compiler/ml/env.ml. Reproduce with the provided npm workspace using npm install and npx rescript build. Done means the transitive-dependency example compiles without Fatal error: exception Not_found and preserves the existing successful cases.
由索引模型根據 Issue 內容生成。
描述
Thank you for filing! Check list:
- Is it a bug? Usage questions should often be asked in the forum instead.
- Concise, focused, friendly issue title & description.
- A minimal, reproducible example.
- OS and browser versions, if relevant.
- Is it already fixed in master? Instructions
bsc exits with a bare Fatal error: exception Not_found (exit code 2) when it compiles Some(x) and the type of x is declared in a package that is only a transitive dependency.
The message names no file, so it is hard to find the module that fails.
Snippet
Three packages in npm workspaces: app (the root) depends on facade, and facade depends on lib-a.
package.json:
{
"name": "app",
"private": true,
"workspaces": ["packages/*"],
"dependencies": {"rescript": "12.3.1"}
}
rescript.json:
{
"name": "app",
"sources": [{"dir": "src"}],
"dependencies": ["facade"]
}
src/App.res:
let x = Some(Facade.v)
packages/facade/package.json:
{"name": "facade", "version": "1.0.0", "dependencies": {"lib-a": "1.0.0"}}
packages/facade/rescript.json:
{"name": "facade", "sources": [{"dir": "src"}], "dependencies": ["lib-a"]}
packages/facade/src/Facade.res:
let v = A.v
packages/lib-a/package.json:
{"name": "lib-a", "version": "1.0.0"}
packages/lib-a/rescript.json:
{"name": "lib-a", "sources": [{"dir": "src"}]}
packages/lib-a/src/A.res:
type t = X
let v = X
npm install
npx rescript build
Actual
Cleaned 0/0
Parsed 3 source files
Compiled 3 modules
Fatal error: exception Not_found
Incremental build failed. Error: Failed to Compile. See Errors Above
The same with the bsc command line from npx rescript compiler-args src/App.res (paths made relative) and a backtrace:
cd lib/bs
OCAMLRUNPARAM=b ../../node_modules/@rescript/linux-x64/bin/bsc.exe -I ../ocaml -runtime-path ../../node_modules/@rescript/runtime -I ../../packages/facade/lib/ocaml -bs-package-name app -bs-package-output commonjs:src:.js src/App.ast
Fatal error: exception Not_found
Raised at Env.find_pers_struct in file "compiler/ml/env.ml", line 699, characters 12-27
Called from Env.find_pers_struct in file "compiler/ml/env.ml" (inlined), line 740, characters 28-54
Called from Env.find_module_descr in file "compiler/ml/env.ml", line 787, characters 8-42
Called from Env.find in file "compiler/ml/env.ml", line 804, characters 25-50
Called from Env.find_type in file "compiler/ml/env.ml" (inlined), line 862, characters 26-48
Called from Typeopt.type_cannot_contain_undefined in file "compiler/ml/typeopt.ml", line 51, characters 17-36
Called from Translcore.transl_exp0 in file "compiler/ml/translcore.ml", lines 829-830, characters 19-32
Called from Translcore.transl_let.transl in file "compiler/ml/translcore.ml", line 1081, characters 18-33
Called from Translmod.transl_structure in file "compiler/ml/translmod.ml", line 371, characters 7-56
Called from Translmod.transl_struct in file "compiler/ml/translmod.ml" (inlined), line 288, characters 2-73
Called from Translmod.transl_implementation in file "compiler/ml/translmod.ml", line 463, characters 16-77
Called from Js_implementation.after_parsing_impl in file "compiler/core/js_implementation.ml", line 147, characters 11-72
Called from Dune__exe__Rescript_compiler_main in file "compiler/bsc/rescript_compiler_main.ml", line 447, characters 6-75
Re-raised at Location.report_exception_rec in file "compiler/ml/location.ml", line 282, characters 14-25
Re-raised at Location.report_exception_rec in file "compiler/ml/location.ml", line 282, characters 14-25
Re-raised at Location.report_exception_rec in file "compiler/ml/location.ml", line 282, characters 14-25
Re-raised at Location.report_exception_rec in file "compiler/ml/location.ml", line 282, characters 14-25
Re-raised at Location.report_exception_rec in file "compiler/ml/location.ml", line 282, characters 14-25
Re-raised at Location.report_exception_rec in file "compiler/ml/location.ml", line 282, characters 14-25
Called from Location.report_exception in file "compiler/ml/location.ml" (inlined), line 288, characters 31-61
Called from Dune__exe__Rescript_compiler_main in file "compiler/bsc/rescript_compiler_main.ml", line 452, characters 4-35
With -I ../../packages/lib-a/lib/ocaml added, the same command exits with 0 and emits let x = Facade.v;.
It crashes the same way when A.t is a record, an abstract type, an @unboxed variant, or type t = int.
It also crashes when Facade re-exports a function of A with an optional labeled argument, and App.res passes Facade.v to it: Facade.f(~a=Facade.v) for let f = (~a: option<t>=?) => a.
It compiles when App.res uses Facade.v without Some: let x = Facade.v or let x = [Facade.v].
Expected
App.res compiles, as it did with ReScript 11.1.4 (see below).
Possible cause: in type_cannot_contain_undefined (compiler/ml/typeopt.ml), Env.find_type p env runs before match decl.type_kind with, so the | exception _ -> false case does not catch its Not_found.
In 11.1.4, the lookup was inside the match expression; it moved out in #7458.
Worked in ReScript 11
The same files with ReScript 11.1.4, and bs-dependencies instead of dependencies in both rescript.json files, build without errors.
lib/js/src/App.js:
// Generated by ReScript, PLEASE EDIT WITH CARE
'use strict';
var Facade = require("facade/lib/js/src/Facade.js");
var Caml_option = require("rescript/lib/js/caml_option.js");
var x = Caml_option.some(Facade.v);
exports.x = x;
/* No side effect */
Environment
- ReScript 12.3.1, 13.0.0-alpha.6, and master
58c6c89(from pkg.pr.new, reports13.0.0-alpha.7): the same crash on all three. - Node.js 24.9.0
- Linux x86_64
Context
We hit it in a test file: a package with test helpers re-exports a test library with include (Lib: module type of Lib), and the test passed a value of an @unboxed variant type from that library to an optional labeled argument.
The tested package lists only the helper package in its dependencies.
Workaround
Add the package that declares the type (lib-a) to the dependencies of the package that fails to compile (app).
- 主要語言
- OCaml
- 星號
- 7.5k
- 分支
- 483
- 平均合併
- 20 小時
- 30 天內合併 PR
- 219
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
rescript-lang/rescript 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 75/100
rescript-lang/rescript#9037 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 12/100
rescript-lang/rescript#9044 · 2 個 reaction ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 35/100
rescript-lang/rescript#9006 · 1 個 reaction ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 70/100
rescript-lang/rescript#8997 ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 68/100
rescript-lang/rescript#8994 ·
維護者通常 1 天內回覆
查看 rescript-lang/rescript 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆
-
enhancement scope:diagnostics scope:syntax
難度 2/5 1-3 小時 新手友好度 77/100
-
code: refactoring good first issue
難度 2/5 1-3 小時 新手友好度 68/100
idris-lang/Idris2#3887 ·
維護者通常 1 天內回覆
-
severity: low
難度 2/5 1-3 小時 新手友好度 72/100
luainkernel/lunatik#2207 ·
維護者通常 1 天內回覆
-
backend:X86 generated by fuzzer llvm:globalisel miscompilation
難度 2/5 1-3 小時 新手友好度 72/100
llvm/llvm-project#235468 · 1 則留言 ·
維護者通常 1 天內回覆