Visual bug in Time mode when the system language used doesn't have AM and PM as default.

未關閉
#782 0 則留言 2 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
45/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
停滯
技術堆疊
javascript, react-native
領域
mobile

研究方向

Start by tracing the Windows implementation of RNDateTimePicker in time mode and how it handles the is24Hour prop and localized AM/PM labels. Reproduce with Portuguese Windows regional settings using the supplied sample; done when the picker displays the expected 24-hour format or AM/PM labels without empty or dotted markers.

由索引模型根據 Issue 內容生成。

描述

windows

Bug report

When the system language of the device used does not have AM and PM as the Time default (in my case, the windows are in Portuguese), the visual part is broken, showing empty for AM and a dot " . " for PM.

image

Reproducible sample code

<RNDateTimePicker mode="time" is24Hour={true} />

Steps to reproduce

  1. Change windows language to portuguese.
  2. launch the app with com RNDateTimePicker in Time Mode.
  3. Open the choose time window to see the visual bug.

Describe what you expected to happen:
It should show AM and PM when the windows language doesn't have AM and PM as default or even with the parameter is24Hour assigned as "true" it should show the default of 24h.

Environment info

System:  Windows 10 (Version: 22H2 OS-Build: 19045.3086)
RN-DateTimePicker Version: "7.1.0"
主要語言
JavaScript
星號
2.9k
分支
459
平均合併
4 天 16 小時
30 天內合併 PR
5

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

react-native-datetimepicker/datetimepicker 的其他 Issue

查看 react-native-datetimepicker/datetimepicker 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。