Update bundled reveal.js to 6.x

未關閉
#15,005 0 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
48/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
javascript

研究方向

Start with the reveal.js version in configuration and the dependency resolution logic in package/src/common/update-html-dependencies.ts; compare both with the 6.x upgrade guide. Check bundled chalkboard, menu, pdfexport, and multiplex plugins for compatibility, then inspect src/resources/formats/html/axe/axe-check.js and the related #14795 work. Done means the bundle and plugin paths work with 6.x, the support-plugin stopgap is removed as appropriate, and the axe scan still checks non-present slides.

由索引模型根據 Issue 內容生成。

描述

maintenance revealjs

We still bundle reveal.js 5.1.0 (we never took 5.2.x).

https://github.com/quarto-dev/quarto-cli/blob/83097c10af6bc5dd50a79b66739f1e34843ee3fb/configuration#L43

reveal.js 6.0 is a major release with breaking path changes (plugins move from plugin/<name> to dist/plugin/, .esm.js becomes .mjs), so this affects how we vendor it and how we resolve plugins. Upgrade guide: https://revealjs.com/upgrading/

https://github.com/quarto-dev/quarto-cli/blob/83097c10af6bc5dd50a79b66739f1e34843ee3fb/package/src/common/update-html-dependencies.ts#L293-L310

Bundled third-party plugins (chalkboard, menu, pdfexport, multiplex) need to be checked against the 6.x API too.

What we would get

  • Off-screen slides marked inert so Tab stays on the current slide (6.0.2, hakimel/reveal.js#1587). We are planning a stopgap in our support plugin for #14795, which mirrors upstream's condition and can be removed with this update.
  • MathJax 4 support (see #14712).

Note for the axe check

reveal.js 6.0.2 sets inert on every non-present slide. axe-core treats an inert subtree as hidden, and our axe check only lifts hidden and aria-hidden before scanning all slides:

https://github.com/quarto-dev/quarto-cli/blob/83097c10af6bc5dd50a79b66739f1e34843ee3fb/src/resources/formats/html/axe/axe-check.js#L474-L499

So with 6.x the axe check also needs to remove inert during the scan and set it back after, otherwise violations on other slides silently stop being reported. The fix for #14795 should already include this change. In that case this update only removes the support plugin stopgap and keeps the axe part.

Related

  • #14795
  • #14712
主要語言
JavaScript
星號
6.1k
分支
478
平均合併
17 小時 26 分鐘
30 天內合併 PR
126

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

quarto-dev/quarto-cli 的其他 Issue

查看 quarto-dev/quarto-cli 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。