CUDA AOTI:`reinterpret_tensor` drops the source tensor's storage offset

未關閉
#24,737 4 則留言 0 個 reaction 已指派 2 人 在 GitHub 檢視

維護者通常 1 天內回覆

@mshr-h 已經在處理了。

開始於 2026年11月9日。

  • #24738 來自 @mshr-h —— 未關閉

評估

難度
3/5
預估耗時
1-2 天
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
cpp

研究方向

Start with backends/cuda/runtime/shims/memory.cpp around aoti_torch__reinterpret_tensor and compare its offset handling with the PyTorch implementation linked in the issue. Then inspect the aoti_torch_as_strided caller, which must pass increment 0 after the offset behavior changes. Done means the reproduction reports offset 6 and first value 6 for increment 2, while increment 0 preserves the source offset; a linked pull request is already open.

由索引模型根據 Issue 內容生成。

描述

bug module: cuda triaged
🐛 Describe the bug

The CUDA backend's aoti_torch__reinterpret_tensor uses the supplied offset as an absolute storage offset. PyTorch adds it to the source tensor's existing offset.

With a CPU source tensor at offset 4, ExecuTorch returns success but selects the wrong elements. Offsets below are in elements.

Increment Expected offset (PyTorch) Actual offset (ExecuTorch)
2 6 2
0 4 0

For increment 2, this reads [2, 3, 4] instead of [6, 7, 8] from storage containing 0, 1, ..., 31.

The ExecuTorch aoti_torch__reinterpret_tensor should add self->storage_offset(), matching PyTorch. Its caller aoti_torch_as_strided must then pass increment 0 to preserve the source offset without adding it twice.

Minimal CPU reproduction

Use a CUDA-enabled editable source build. Save this as minimal_repro.cpp beside the executorch/ clone. The build requires CUDA tooling and runtime libraries but no GPU required for reproduction.

#include <executorch/backends/aoti/slim/factory/from_blob.h>
#include <executorch/backends/cuda/runtime/shims/memory.h>
#include <executorch/runtime/platform/platform.h>

#include <cstdio>

int main() {
  using namespace executorch::backends;
  using executorch::runtime::Error;
  et_pal_init();
  float data[32];
  for (int i = 0; i < 32; ++i) {
    data[i] = static_cast<float>(i);
  }
  auto source = aoti::slim::from_blob(
      data, {3, 4}, {4, 1}, aoti::slim::c10::ScalarType::Float,
      aoti::slim::CPU_DEVICE, 4);
  const int64_t sizes[] = {3};
  const int64_t strides[] = {1};
  cuda::SlimTensor* view = nullptr;
  auto error = cuda::aoti_torch__reinterpret_tensor(
      &source, 1, sizes, strides, 2, &view);
  if (error != Error::Ok || view == nullptr) {
    return 1;
  }
  std::printf(
      "source_offset=%lld increment=2 expected_offset=6 actual_offset=%lld "
      "first_value=%.0f\n",
      static_cast<long long>(source.storage_offset()),
      static_cast<long long>(view->storage_offset()),
      *static_cast<float*>(view->data_ptr()));
  return cuda::aoti_torch_delete_tensor_object(view) == Error::Ok ? 0 : 1;
}

From the ExecuTorch clone, compile and run it against the editable build's libraries:

ET_SOURCE="$PWD"
mkdir -p ../artifacts
c++ -std=c++17 -DC10_USING_CUSTOM_GENERATED_MACROS \
  -I"$ET_SOURCE/.." -I"$ET_SOURCE" \
  -I"$ET_SOURCE/runtime/core/portable_type/c10" \
  ../minimal_repro.cpp \
  "$ET_SOURCE/backends/cuda/libaoti_cuda_shims.so" \
  "$ET_SOURCE/src/executorch/lib/libexecutorch.so" \
  -Wl,-rpath,"$ET_SOURCE/backends/cuda" \
  -Wl,-rpath,"$ET_SOURCE/src/executorch/lib" \
  -o ../artifacts/minimal_repro_standalone
../artifacts/minimal_repro_standalone

Observed on the unmodified library:

source_offset=4 increment=2 expected_offset=6 actual_offset=2 first_value=2
Versions

PyTorch version: 2.14.0+cu130
Is debug build: False
CUDA used to build PyTorch: 13.0
ROCM used to build PyTorch: N/A

OS: Ubuntu 24.04.5 LTS (aarch64)
GCC version: (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0
Clang version: Could not collect
CMake version: version 3.31.10
Libc version: glibc-2.39

Python version: 3.12.13 (main, Apr 14 2026, 14:26:08) [Clang 22.1.3 ] (64-bit runtime)
Python platform: Linux-7.0.0-1024-nvidia-aarch64-with-glibc2.39
Is CUDA available: True
CUDA runtime version: 13.0.88
CUDA_MODULE_LOADING set to:
GPU models and configuration: GPU 0: NVIDIA GB10
Nvidia driver version: 580.178.04
cuDNN version: Probably one of the following:
/usr/lib/aarch64-linux-gnu/libcudnn.so.9.27.0
/usr/lib/aarch64-linux-gnu/libcudnn_adv.so.9.27.0
/usr/lib/aarch64-linux-gnu/libcudnn_cnn.so.9.27.0
/usr/lib/aarch64-linux-gnu/libcudnn_engines_precompiled.so.9.27.0
/usr/lib/aarch64-linux-gnu/libcudnn_engines_runtime_compiled.so.9.27.0
/usr/lib/aarch64-linux-gnu/libcudnn_engines_tensor_ir.so.9.27.0
/usr/lib/aarch64-linux-gnu/libcudnn_ext.so.9.27.0
/usr/lib/aarch64-linux-gnu/libcudnn_graph.so.9.27.0
/usr/lib/aarch64-linux-gnu/libcudnn_heuristic.so.9.27.0
/usr/lib/aarch64-linux-gnu/libcudnn_ops.so.9.27.0
Is XPU available: False
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: False
Caching allocator config: N/A

CPU:
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 20
On-line CPU(s) list: 0-19
Vendor ID: ARM
Model name: Cortex-X925
Model: 1
Thread(s) per core: 1
Core(s) per socket: 10
Socket(s): 1
Stepping: r0p1
Frequency boost: disabled
CPU(s) scaling MHz: 100%
CPU max MHz: 3900.0000
CPU min MHz: 1378.0000
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh bti ecv afp wfxt
Model name: Cortex-A725
Model: 1
Thread(s) per core: 1
Core(s) per socket: 10
Socket(s): 1
Stepping: r0p1
CPU(s) scaling MHz: 100%
CPU max MHz: 2808.0000
CPU min MHz: 338.0000
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh bti ecv afp wfxt
L1d cache: 1.3 MiB (20 instances)
L1i cache: 1.3 MiB (20 instances)
L2 cache: 25 MiB (20 instances)
L3 cache: 24 MiB (2 instances)
NUMA node(s): 1
NUMA node0 CPU(s): 0-19
Vulnerability Gather data sampling: Not affected
Vulnerability Ghostwrite: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Old microcode: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected

Versions of relevant libraries:
[pip3] executorch==1.6.0+ad3b6d2
[pip3] flake8==6.1.0
[pip3] flake8-breakpoint==1.1.0
[pip3] flake8-bugbear==24.4.26
[pip3] flake8-comprehensions==3.14.0
[pip3] flake8-plugin-utils==1.3.3
[pip3] flake8-pyi==23.5.0
[pip3] mypy==1.14.1
[pip3] mypy_extensions==1.2.0
[pip3] numpy==2.5.4
[pip3] nvidia-cublas==13.1.1.3
[pip3] nvidia-cuda-cupti==13.0.85
[pip3] nvidia-cuda-nvrtc==13.0.88
[pip3] nvidia-cuda-runtime==13.0.96
[pip3] nvidia-cudnn-cu13==9.24.0.43
[pip3] nvidia-cufft==12.0.0.61
[pip3] nvidia-curand==10.4.0.35
[pip3] nvidia-cusolver==12.0.4.66
[pip3] nvidia-cusparse==12.6.3.3
[pip3] nvidia-cusparselt-cu13==0.8.1
[pip3] nvidia-nccl-cu13==2.30.7
[pip3] nvidia-nvjitlink==13.5.37
[pip3] nvidia-nvtx==13.0.85
[pip3] pytorch_tokenizers==1.4.0
[pip3] torch==2.14.0+cu130
[pip3] torchao==0.19.0.dev20261103+cpu
[pip3] triton==3.8.0+gitdf3f91dd
[conda] Could not collect

cc @Gasoonjia @digantdesai

主要語言
Python
星號
5.2k
分支
1.2k
平均合併
2 天 21 分鐘
30 天內合併 PR
708

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

pytorch/executorch 的其他 Issue

查看 pytorch/executorch 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。