Possible `NULL`-related `SystemError` when interpreter is not fully initialized

未關閉
#161,863 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
65/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
c, python
領域
backend

研究方向

Read Python/import.c around lines 3921–3922 and the IMPORTLIB(interp) definition around lines 95–96 to understand how the null value reaches this path. Reproduce with the _freeze_module command shown in the issue, then check the error handling and tests for this import path. Done means the incomplete initialization case reports a clear SystemError explaining that imports are not fully initialized; the issue also mentions fixing freeze later.

由索引模型根據 Issue 內容生成。

描述

interpreter-core topic-importlib type-bug

Code: https://github.com/python/cpython/blob/9f386367333f7845095d764fad3ad9b397d04672/Python/import.c#L3921-L3922

Here IMPORTLIB(interp) can be NULL under rare conditions:

https://github.com/python/cpython/blob/9f386367333f7845095d764fad3ad9b397d04672/Python/import.c#L95-L96

For example, when interpreter is not yet fully initialized.

Output:

» ./Programs/_freeze_module crash crash.py crash.h
Exception ignored in the internal traceback machinery:
SystemError: null argument to internal routine
# ...

Refs https://github.com/python/cpython/pull/161860 where I first found this case.
Refs https://github.com/python/cpython/issues/142662 where the initial reproducer was found.

I guess we should raise a different SystemError here with the text that imports are not yet fully initialized.

My proposal is to make the error message better here: it should state the interpreter is not fully initialized.

And ideally we can fix the freeze command as well later.

主要語言
Python
星號
78.2k
分支
36.6k
平均合併
19 小時 57 分鐘
30 天內合併 PR
630

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

python/cpython 的其他 Issue

查看 python/cpython 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。