frameobject: undefined 32-bit left shifts in `stack_swap()`

未關閉
  • 哪裡不對？
#161,666 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
c, python
領域
backend

研究方向

The undefined shifts are in stack_swap() in Objects/frameobject.c, around line 1323, where MASK and top are shifted as 32-bit values. Read it alongside mark_stacks and frame_setlineno(), which call it. Run the reproducer under UBSan to see the shift warnings. Done means the shifts operate on 64-bit values and the sanitizer run is clean. The issue already links PR gh-161667, so check that before starting.

由索引模型根據 Issue 內容生成。

描述

interpreter-core type-crash
Crash report

stack_swap() in Objects/frameobject.c shifted MASK and top as
32-bit values and converted the result to int64_t, while the value-stack
model is a 63-bit int64_t and shift = BITS_PER_BLOCK*(n-1) can reach 60.
The shifts overflow / drop bits (undefined behavior) and corrupt the stack
model used by frame_setlineno() to validate line jumps.

import dis
import sys

fors = " ".join(f"for v{i} in range(1)" for i in range(11))
ns = {}
exec(f"def f():\n    return [0 {fors}]\n", ns)
f = ns["f"]

triggered = False
def tracer(frame, event, arg):
    global triggered
    if event == "line" and frame.f_code is f.__code__ and not triggered:
        triggered = True
        frame.f_lineno = frame.f_lineno  # mark_stacks -> stack_swap
    return tracer

sys.settrace(tracer)
try:
    f()
finally:
    sys.settrace(None)

UBSan output:

Objects/frameobject.c:1323:44: runtime error: shift exponent 33 is too large for 32-bit type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/frameobject.c:1323:44 in 
Objects/frameobject.c:1323:62: runtime error: shift exponent 33 is too large for 32-bit type 'unsigned int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/frameobject.c:1323:62 in

Found by Linux Verification Center (linuxtesting.org) with SVACE

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Output from running 'python -VV' on the command line:

No response

Linked PRs
  • gh-161667
主要語言
Python
星號
78.2k
分支
36.6k
平均合併
19 小時 57 分鐘
30 天內合併 PR
630

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

python/cpython 的其他 Issue

查看 python/cpython 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。