Django integration is incompatible with Django REST Framework
還沒有人認領這個 Issue。
評估
研究方向
Review the DjangoOpenAPIRequest class and the linked Django REST Framework issue first. Compare request.body and request.data behavior for a DRF Request, then determine an integration approach; done means DRF requests no longer fail because POST data is read twice.
由索引模型根據 Issue 內容生成。
描述
The DjangoOpenAPIRequest class accesses request.body. This can cause issues related to reading the POST data twice, as described here:
https://github.com/encode/django-rest-framework/issues/2774
I have found that DRF accesses the request.body to read the CSRF token so the mitigation steps described in the issue above do not work. I have a branch of openapi-core here:
https://github.com/jrtcppv/openapi-core
That instead reads request.data and bypasses the deserialization of the request body. This is probably not the right solution as it is, but it might be possible to inspect the type of the request and do something different if it is not a normal django HttpRequest class, but rather the Request class provided by DRF.
I also tried subclassing DRF's APIView and overriding the intialize_request function, returning a subclass of Request that contained the parameters parsed by openapi-core. This also worked and might be an option if there needs to be a separate integration just for DRF.
Anyway, thanks for the library!
- 主要語言
- Python
- 星號
- 368
- 分支
- 140
- PR 合併指標
- 30 天內沒有已合併 PR
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
python-openapi/openapi-core 的其他 Issue
-
kind/bug
難度 2/5 1-3 小時 新手友好度 68/100
python-openapi/openapi-core#1188 · 2 則留言 ·
-
kind/bug
難度 3/5 1-2 天 新手友好度 68/100
python-openapi/openapi-core#1225 · 2 則留言 ·
-
kind/bug
難度 3/5 1-2 天 新手友好度 76/100
python-openapi/openapi-core#1212 ·
-
kind/bug
難度 3/5 1-2 天 新手友好度 68/100
python-openapi/openapi-core#1210 ·
-
kind/bug kind/bug/confirmed
難度 3/5 1-2 天 新手友好度 58/100
python-openapi/openapi-core#1180 · 3 則留言 ·
查看 python-openapi/openapi-core 的全部 Issue
相似的 Issue
-
bug confirmed issue
難度 2/5 1-3 小時 新手友好度 75/100
open-webui/open-webui#30750 · 1 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 75/100
-
enhancement
難度 2/5 1-3 小時 新手友好度 75/100
OpenwaterHealth/openmotion-bloodflow-app#604 · 1 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
-
good first issue
難度 1/5 1 小時以內 新手友好度 90/100