Consistency for Eq a / Ord a functions with suffix "By"
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 30/100
- Issue 類型
- 功能
- 描述清晰度
- 基本清楚
- 活躍度
- 停滯
- 領域
- api
研究方向
Read the array API definitions for difference, elem, notElem, elemIndex, and elemLastIndex, then compare their signatures and naming with the existing By variants listed in the issue. Decide whether differenceBy fits the API’s conventions and identify the corresponding functions to address. Done means the API naming and custom equality support are consistent; the issue provides no file or test paths to start from.
由索引模型根據 Issue 內容生成。
描述
As I look through the API, I see a pretty consistent pattern of "You can rely on a typeclass for Eq/Ord or you can supply your own".
So if a type signature has forall a. Eq a => ..., there's often a version that removes this constraint and adds in a function like forall a. (a -> a -> Boolean) ...
There even seems like a pretty consistent naming pattern:
insert & insertBy
sort & sortBy
group & groupBy
groupAll & groupAllBy
nub & nubBy
nubEq & nubByEq <- Sort of a break from the pattern, but still
union & unionBy
delete & deleteBy
intersect & intersectBy
But it feels sort of arbitrary when some functions don't follow that pattern
For example: difference
I'd expect to see
difference :: forall a. Eq a => Array a -> Array a -> Array a
differenceBy :: forall a. (a -> a -> Boolean) -> Array a -> Array a -> Array a
The same holds for elem, notElem, elemIndex, and elemLastIndex, but these are covered by find >>> isJust, find >>> isNothing, findIndex, and findLastIndex. I understand a departure in naming pattern here since Eq a is replaced with (a -> Boolean) instead of (a -> a -> Boolean).
- 主要語言
- PureScript
- 星號
- 58
- 分支
- 70
- 平均合併
- 2 天 22 小時
- 30 天內合併 PR
- 1
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 沒有貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
purescript/purescript-arrays 的其他 Issue
-
難度 1/5 1 小時以內 新手友好度 55/100
purescript/purescript-arrays#246 ·
-
難度 2/5 1-3 小時 新手友好度 35/100
purescript/purescript-arrays#244 · 2 則留言 ·
-
難度 4/5 3-5 天 新手友好度 35/100
purescript/purescript-arrays#242 · 2 則留言 ·
-
難度 4/5 3-5 天 新手友好度 35/100
purescript/purescript-arrays#241 ·
-
`groupBy` has unexpected `l` argument for `a -> a -> Boolean` predicate可能重新可做 關聯的 PR 已關閉且未合併。 未關閉
難度 2/5 1-3 小時 新手友好度 25/100
purescript/purescript-arrays#229 · 3 則留言 ·
查看 purescript/purescript-arrays 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 72/100
ROCm/rocm-libraries#15866 ·
維護者通常 2 天內回覆
-
area: web
難度 2/5 1-3 小時 新手友好度 72/100
inabagumi/shinju-date#6823 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 62/100
-
ManageSieve proxy: a backend's NO/BYE greeting is skipped as a capability line and reported as EOF未關閉bug
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 82/100
dmtrKovalenko/odiff#191 ·