[BUG] Patch.update mutates a shared mapping and rewrites earlier merges

未關閉
#4,143 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@peterolkhov 已經在處理了。

開始於 2026年11月12日。

  • #4144 來自 @peterolkhov —— 未關閉

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
python
領域
backend

研究方向

Start by locating Patch.update and the code that records its merge operations; the issue provides a reproducer using a shared dictionary and to_json. Check the existing Patch tests for merge behavior, then verify that each location keeps its own amount and the input dictionary remains unchanged. Pull request #4144 is already open for this issue.

由索引模型根據 Issue 內容生成。

描述

Patch.update uses its nonempty dictionary argument as the target for merging
keyword arguments. Reusing that dictionary for two locations in one callback
changes the value already queued for the first location.

import json

from dash import Patch
from dash._utils import to_json

common = {"currency": "USD"}
p = Patch()
p["jan"].update(common, amount=100)
p["feb"].update(common, amount=200)
print(json.dumps(json.loads(to_json(p)), indent=2))
print(common)

Expected merge values are {"currency": "USD", "amount": 100} for jan
and {"currency": "USD", "amount": 200} for feb. common should remain
{"currency": "USD"}. Both serialized merge values instead contain
"amount": 200, and common also gains "amount": 200.

The same callback was exercised in a running Dash app with a dcc.Store and
Chrome. Its actual Store data had amounts 200/200 instead of 100/200. Existing
fields at each location were retained. Distinct dictionary arguments and
keyword-only calls produced the expected 100/200 values.

The native diagnostic run is
https://github.com/peterolkhov/dash/actions/runs/43130587651/job/130893438856.
It checks the actual public producer and running browser, with two ordinary
assertion failures for the shared mapping and four passing controls.

Environment: unchanged Dash dev commit
b5a33c5b9191bef976e352b9feca14eaf93c9b7a, Dash 4.5.0, Python 3.12.16,
Node 24.22.2, Selenium 4.51.0, Chrome/ChromeDriver 157.0.8103.78, and Ubuntu
on a standard GitHub-hosted runner. The full npm run build completed first.

AI assistance was used to investigate and prepare this report. The observed
results above come from the linked native run.

主要語言
Python
星號
24.5k
分支
2.3k
平均合併
3 天 7 小時
30 天內合併 PR
30

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

plotly/dash 的其他 Issue

查看 plotly/dash 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。