Research: ConnectionInterface contract for final driver Connection classes
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start with phpdb-mysql's test/unit/ConnectionTest.php, especially createMockConnection(), then trace the upstream interfaces and Connection::connect(), createResource(), and setResource(). Done means the resource-factory contract and approach for final driver Connection classes are decided and the PHPUnit failure mode is covered by the relevant tests.
由索引模型根據 Issue 內容生成。
描述
Context
Researching whether phpdb-mysql's Connection class can be made final ahead of its 1.0.0 release. This will need a resource-factory contract designed here in php-db/phpdb, since the same problem will apply to every driver package. Still tracing the upstream interfaces and deciding on an approach, not rushed.
Root cause of the test failures
phpdb-mysql's test/unit/ConnectionTest.php::createMockConnection() uses a PHPUnit partial mock:
$connection = $this->getMockBuilder(Connection::class)
->onlyMethods(['createResource'])
->setConstructorArgs([$params])
->getMock();
onlyMethods() partial mocking works by generating a real subclass of Connection at runtime with the specified method overridden. Marking Connection final breaks this, since PHP does not allow subclassing a final class. This throws:
PHPUnit\Framework\MockObject\Generator\ClassIsFinalException: Class "PhpDb\Mysql\Connection" is declared "final" and cannot be doubled
Also confirmed that calling setResource() with a fake resource before connect() does not work as a substitute. connect()'s first line is if ($this->resource instanceof mysqli) { return $this; }. Once a resource is set, connect() treats that as already connected and returns immediately, skipping the DSN and SSL flag building logic and the real_connect() call that the tests need to exercise.
- 主要語言
- PHP
- 星號
- 18
- 分支
- 8
- 平均合併
- 6 天 11 小時
- 30 天內合併 PR
- 14
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 沒有貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
php-db/phpdb 的其他 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
RFC
難度 3/5 1-2 天 新手友好度 66/100
維護者通常 1 天內回覆
-
RFC
難度 5/5 一週以上 新手友好度 38/100
維護者通常 1 天內回覆
-
RFC
難度 3/5 1-2 天 新手友好度 68/100
維護者通常 1 天內回覆
-
RFC
難度 4/5 3-5 天 新手友好度 45/100
維護者通常 1 天內回覆
相似的 Issue
-
product / databases
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
enhancement
難度 2/5 1-3 小時 新手友好度 75/100
VilnaCRM-Org/user-service#525 ·
維護者通常 21 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
shukiv/jabali-panel#2029 ·
維護者通常 1 天內回覆
-
area:pool-types good first issue priority:low type:bug
難度 2/5 1-3 小時 新手友好度 76/100
crazy-goat/php-fpm-ng#822 ·
維護者通常 1 天內回覆
-
agentic bug
難度 2/5 1-3 小時 新手友好度 78/100
MagnaCapax/PMSS#1023 · 1 則留言 ·
維護者通常 5 天內回覆