A failed rollback leaves a mix of old and new files

未關閉
#71 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
cpp, python
領域
desktop-dev

研究方向

Start in Rollback in clean/installer/src/wg_core/launcher.cpp, around lines 615-654, where files are copied into .swap, overwritten one at a time by CopyChecked, and the record is saved last. Check how RunOp turns the exception into an error result, and how the retry path clears .swap with RemoveTree near line 629. The new test is the one in tests/run_launcher_tests.py, which needs a file held open with FILE_SHARE_READ only. Done means a failed rollback restores the first live file's current bytes and leaves .swap in place when the undo itself fails.

由索引模型根據 Issue 內容生成。

描述

area: launcher bug

This was found by reading the code. It has not been reproduced.

What happens

Rollback (clean/installer/src/wg_core/launcher.cpp:615) copies the current files into .swap. It then overwrites the live files one at a time with CopyChecked (launcher.cpp:636-643). There is no catch and no undo. The record is saved only at the end (launcher.cpp:654). RunOp turns an exception into an error result. A retry runs RemoveTree(swap) first (launcher.cpp:629) and rebuilds .swap from the now-mixed live files.

If the loop fails halfway, the live files are a mix of two versions. The folder the player would use to roll back again (the new previous\, built from .swap) is mixed too.

No player file is lost. previous\ is untouched and verified, so a retry finishes the rollback. The record's hashes no longer match the live files, so the verify step suggests a repair (launcher.cpp:930). Repair or Update recovers.

When it can happen

Unusual but innocent. The game running is already blocked (launcher.cpp:618). What remains is another program holding a payload DLL without write sharing, a full disk, or a crash during the copy loop. Until the player retries or repairs, the game may fail to start or crash with mixed DLLs. Low severity.

To do

  • Wrap the copy loop in try/catch. On failure, copy back the files already replaced from .swap (the hashes are in its previous.txt) before rethrowing.
  • Do not delete .swap on a later run while the record's version still differs from what .swap\previous.txt names.
  • Caution: the undo can fail on the same lock. It should then leave .swap in place and say so.

Test

CPU-only. Fake install with previous\ holding two payload files whose bytes differ. Hold the second live file open with FILE_SHARE_READ only. Run Rollback. Assert it fails and the first live file has its current bytes again. The existing test (tests/run_launcher_tests.py:371-401) uses identical payloads, so it cannot catch this.

主要語言
C++
星號
12
分支
2
平均合併
3 小時 10 分鐘
30 天內合併 PR
171

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

phantoslayer21/wronggpu 的其他 Issue

查看 phantoslayer21/wronggpu 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。