Model M releases its resources after a drain timeout, though game lists may use them

未關閉
#62 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
22/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
cpp
領域
devtools

研究方向

Start in clean/runtime/interop/executor_d3d12.cpp: drain() around line 329 and the destructor around line 52, which releases proxy16_, proxy32_, mpoint_ and retired_. Then check device_d3d12.cpp at lines 146-185 for the retain-on-failure path. The test seam is in dx12/tests/native_direct_test.cpp using the WARP Gpu helper near line 46. Done means drain() returns bool, the destructor retains the runtime on timeout when the device is not removed, and the WARP test confirms a probe object is not released.

由索引模型根據 Issue 內容生成。

描述

area: runtime bug needs-hardware-test

What happens

D3d12Executor::drain() (clean/runtime/interop/executor_d3d12.cpp:329) polls external_done() < external_recorded() for up to 5000 × Sleep(1). It returns void. On timeout it only logs.

The destructor (:52) then calls begin_teardown() and runtime_destroy(rt_) unconditionally, and releases proxy16_, proxy32_, mpoint_ and retired_ (:59-:61). The game's recorded list references these objects (df.output, df.motion, the copy16 source).

runtime_destroy ends in the device destructor (clean/runtime/device_d3d12.cpp:146). Its "retain on failure" path (:148-:163) depends only on finish_queue() (:869), which submits to and waits on the device's own create-time queue. It does not look at external_done(). When that succeeds, :166-:185 releases the arena, PSOs, descriptor heap, root signatures, direct textures and the marker.

shutdown (clean/runtime/interop/backend.cpp:1933) calls exec_->drain() and then exec_.reset(). Nothing else waits.

When it can happen

Only if the game's list runs more than 5 s after the destroy call. Two cases:

  • The game records a dispatch and destroys the context before it submits that list, on the same thread (for example a settings or resize handler in the middle of a frame). The wait can never succeed, so the game thread freezes for 5 s, and the game then submits a list whose resources have been freed.
  • The queue is stalled for more than 5 s without device removal. This is rare, because a driver timeout normally fires first.

In the common case the front end parks destroyed contexts (clean/fsr/src/frontend.h:156), so the executor is not torn down when the game calls destroy. Most engines also flush the GPU before releasing an upscaler. The backend's own contract says destroy "waits for in-flight work" (clean/fsr/include/wronggpu_upscaler.h:210); it does not say unsubmitted work is safe.

The impact is device removal. The probability is low.

Found by reading the code. It has not been reproduced.

To do

This is the minimal fix, matching the device's existing policy at device_d3d12.cpp:157-:163:

  • Make drain() return bool.
  • In ~D3d12Executor, if the drain timed out and GetDeviceRemovedReason() is S_OK: log it and retain the whole runtime. Skip begin_teardown, runtime_destroy and the proxy, mpoint_ and retired_ releases, and deliberately leak rt_.
  • If the device is removed, release as now.

The cost is a leak of the arena (the size of the network) plus the proxies, per occurrence, until the process exits. A new context on the same device then has less VRAM; the OOM wait at device_d3d12.cpp:1170 copes by waiting and failing cleanly. A later improvement would be a process-wide list that keeps the executor and releases it once external_done() catches up.

Test

CPU / WARP, with a seam so external_done() can be faked. dx12/tests/native_direct_test.cpp has a WARP Gpu helper (:46). Call begin_external and end_external on a list that is never executed, destroy the device, and assert that a tracked probe object was not released. A GPU test is needed for the full executor path.

Related: #63, #58 (objects released while a recorded list may still use them), #68.

主要語言
C++
星號
12
分支
2
平均合併
3 小時 10 分鐘
30 天內合併 PR
171

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

phantoslayer21/wronggpu 的其他 Issue

查看 phantoslayer21/wronggpu 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。