0.6.6: RR kernel cache key should hash only the inputs of RR kernels

未關閉
#263 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
52/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
cpp

研究方向

Start with clean/dx12/build_dx12.py and trace how it gathers RR kernel sources and includes, compiler details, flags, defines, and builds the cache key. Add the requested test for unrelated edits versus changes to each RR input, then run the relevant build and test commands; done means unrelated edits preserve the key while RR input changes invalidate it.

由索引模型根據 Issue 內容生成。

描述

The Ray Reconstruction kernel cache key includes the full text of clean/dx12/build_dx12.py. Any change to that file, even one that has nothing to do with Ray Reconstruction kernels (for example a new check for another model's shaders), invalidates the whole cache, and the next full build recompiles every RR kernel. That takes about three hours on a two-job build.

Proposal: make the key hash only the inputs that affect RR kernels: their sources and include closure, the compiler and its version, the flags and defines used for RR kernels, and the specific code that turns those into a compile command. Add a test showing that an unrelated edit to build_dx12.py keeps the key, and that a change to an RR source, include, flag or define changes it.

主要語言
C++
星號
12
分支
2
平均合併
3 小時 10 分鐘
30 天內合併 PR
171

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

phantoslayer21/wronggpu 的其他 Issue

查看 phantoslayer21/wronggpu 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。