Dependency count and bundle size increases are time-based, but should compare to nearest applicable version

未關閉
#3,333 0 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
54/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
nuxt, typescript

研究方向

Start by locating the code that generates dependency count and bundle size warnings and read how it chooses the comparison release. Reproduce the Storybook 11 alpha and backport case, then trace how semver could select the nearest applicable version. Done means both warnings compare against the expected release for the examples in the issue.

由索引模型根據 Issue 內容生成。

描述

back e18e front
Describe the bug

We believe the dependency count and bundle size warnings are based off release timing, leading to comical comparisons when a team releases bug fixes with backports :)

For instance here, we released a Storybook 11 alpha alongside 3 security backports for 8, 9 and 10. Storybook 11.0 a6 is compared to Storybook 9 but comparing to 11.0 a5 would make more sense.

Image

Here Storybook 9 is compared to Storybook 8, even though the storybook 8 package was an empty shell back in the day.

Image
Additional context

I think comparing to the previous semantic release would fix that. A X.0.0 major could compare to the previous stable release, but patch and minor releases would naturally compare to the code in their branch if doing based on semver.

Logs

主要語言
TypeScript
星號
3.6k
分支
533
平均合併
2 天 21 小時
30 天內合併 PR
56

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

npmx-dev/npmx.dev 的其他 Issue

查看 npmx-dev/npmx.dev 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。