test_runner: MockTimers does not support Temporal
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 48/100
- Issue 類型
- 功能
- 描述清晰度
- 基本清楚
- 活躍度
- 冷清
- 技術堆疊
- javascript
- 領域
- testing-qa
研究方向
從 node:test MockTimers API 開始,使用 issue 中的範例重現文件所述的 Temporal 失敗。檢視對 issue #63312 的依賴,並確定 Temporal.Now 應如何與 Date 共用模擬時鐘。完成的標準是:如描述所述,可以透過 MockTimers 選取、推進和凍結 Temporal,且列出的 Temporal.Now 方法能以決定性的方式運作。
由索引模型根據 Issue 內容生成。
描述
What is the problem this feature solves?
As of Node.js 26, Temporal is enabled by default (#62526), and the platform is in the process of growing Temporal support across its APIs (#57891, #63154, #63312). One gap that doesn't seem to be tracked anywhere yet: node:test's MockTimers has no way to control Temporal.Now.
MockTimers.enable({ apis }) accepts 'setTimeout' | 'setInterval' | 'setImmediate' | 'Date'. Passing 'Temporal' (or any Temporal-related token) throws ERR_INVALID_ARG_VALUE. There is also no documented way to advance / freeze Temporal.Now.instant(), Temporal.Now.zonedDateTimeISO(), etc. via the mock clock.
Concretely, this means any code that reads "now" via Temporal.Now instead of Date.now() can't be tested deterministically with the built-in test runner. With Temporal now being the recommended way to do date/time work, this is increasingly the common case — code migrating away from Date loses its ability to use MockTimers for time-based assertions.
Repro
import { mock } from "node:test";
mock.timers.enable({ apis: ["Temporal"] });
// TypeError [ERR_INVALID_ARG_VALUE]: The property 'options.apis' must be one of:
// ['setTimeout', 'setImmediate', 'setInterval', 'Date']
mock.timers.enable({ apis: ["Date"], now: 0 });
console.log(new Date().toISOString()); // 1970-01-01T00:00:00.000Z (mocked)
console.log(Temporal.Now.instant().toString()); // current real time (NOT mocked)
What is the feature you are proposing to solve the problem?
Extend MockTimers so that, when Temporal is in the apis list, the following are tied to the mock clock:
Temporal.Now.instant()Temporal.Now.zonedDateTimeISO(timeZone?)Temporal.Now.plainDateTimeISO(timeZone?)Temporal.Now.plainDateISO(timeZone?)Temporal.Now.plainTimeISO(timeZone?)Temporal.Now.timeZoneId()(probably leave passthrough; only the clock should be virtual)
mock.timers.tick(ms) and mock.timers.setTime(ms) should advance Temporal's view of "now" the same way they advance Date.now(). The natural ergonomic is for 'Date' and 'Temporal' to be independently selectable but to share one underlying mock clock (so a test can mock both and have them agree).
This likely depends on #63312 (internal Temporal utils) landing first, since MockTimers would need a way to construct Temporal.Instants from the mock epoch ms without round-tripping through Date.
What alternatives have you considered?
- Userland: wrap
Temporal.Nowin a project-level abstraction that reads from a clock the tests can mock. Works but is viral — every consumer has to use the wrapper. - Userland: monkey-patch
Temporal.Nowin test setup. Brittle and doesn't compose withmock.timers. @sinonjs/fake-timershas the same gap upstream, so dropping the built-in runner doesn't help.
Filing per discussion in nodejs/node#57891 (which explicitly scopes out test_runner/generic support) — happy to take this on if there's interest and #63312 looks close to landing.
- 主要語言
- JavaScript
- 星號
- 122k
- 分支
- 37.4k
- 平均合併
- 4 天 2 小時
- 30 天內合併 PR
- 277
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
nodejs/node 的其他 Issue
-
doc
難度 2/5 1-3 小時 新手友好度 65/100
-
build
難度 1/5 1 小時以內 新手友好度 88/100
-
難度 2/5 1-3 小時 新手友好度 84/100
-
難度 1/5 1 小時以內 新手友好度 90/100
-
feature request
難度 2/5 1-3 小時 新手友好度 68/100
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 65/100
antfu-collective/icones#398 ·
-
ECmail.com 未關閉
難度 1/5 1 小時以內 新手友好度 90/100
wesbos/burner-email-providers#554 ·
-
難度 2/5 1-3 小時 新手友好度 65/100
radiantearth/stac-browser#1023 ·
-
難度 2/5 1-3 小時 新手友好度 75/100
-
難度 2/5 1-3 小時 新手友好度 75/100
components-web-app/docs#92 ·