Proposal: Reduce moderator permissions and document what moderators can and cannot do
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 30/100
- Issue 類型
- 功能
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- github
研究方向
先從此提案和連結的 openjs-foundation/summit#511 討論開始,然後閱讀 Moderation-Policy.md 和 ONBOARDING.md。審查在 nodejs/moderation 中記錄決策的現有要求。達成共識、指定升級處理負責人、記錄政策和 onboarding 的界線,並完成所述的權限變更,即表示完成。
由索引模型根據 Issue 內容生成。
描述
Part of the moderation policy review framed by openjs-foundation/summit#511, for discussion at the Moderation Roundtable on October 1 (if not resolves to consensus prior).
Moderation staff hold org-wide control of Node.js
Because the Moderation Policy assumes org-owner access, eight moderation team members currently hold immense permissions incongruent with their typical role requirements. This makes them targets for threat actors.
Org-owner means the ability to:
- Delete any repository in the organization
- Read and rotate organization secrets and tokens
- Override branch protection and push to protected branches
- Alter CI/CD workflows
- Add or remove organization members
- Transfer repositories out of the organization
- Manage billing
That is a lot of power to hold for a role whose daily work is de-escalating conflict, closing or hiding spam, and blocking drive-by accounts. I suggest it is not power any of us needs in order to moderate.
Any one of those eight accounts, compromised, gives an attacker a lot of space to vandalize the project or cause harm. We have recently seen attacks targeting Node.js maintainers. This proposal may be the most security-minded improvement we can make to Node.js.
Reduce to what moderation actually requires
- Retain the Organization Moderator role
- Remove org-owner from anyone who does not hold it for other reasons
- Keep their existing write access to the private
nodejs/moderationrepo - Add explicit write access to nodejs/node - the repo with the most activity
[!NOTE]
This will not cover everything. That is the tradeoff, but it feels necessary to reduce risk.
This proposal is to write the resulting boundaries into the policy so that moderators, reporters, and Collaborators all know where the limits sit.
The boundaries this creates
Any moderator can do these, across every public repo in the organizations, without asking anyone:
- Block and unblock non-members: spammers, bots, drive-by CoC violations
- Set interaction limits, org-wide or per repository
- Hide and unhide comments
A moderator can do these only where they already have write on the repository, which most of us do on the repos we work in as Collaborators:
- Edit, delete, or lock posts
- Hide comments in private repos, which the Moderator role does not reach
[!WARNING]
There is no way to extend this org-wide without granting write on every repository, and write includes push. Hiding is the action that works everywhere, and it is reversible and leaves an audit trail, so it should be the default.
These existing (potential) moderation team actions now require escalation
These seem to be the actions we have historically needed org-ownership for, yet, in practice, occur rarely. We don't need powerful permissions for such rare occurrences. But we should document what we'd do in these cases:
- Removing someone from the organization
- Blocking a Collaborator, which GitHub only permits after org removal
The process: document the decision in nodejs/moderation as the policy already requires, then request execution. Org owners engaged.
Moderators can no longer do these at all, and should not be asked to:
- Anything on the org-owner list above
The open question
Who holds owner for escalations, and how are they designated? Does the TSC have this power? Chairs only? Easy to determine and document.
Action items
- Consensus the change is warranted considering AS-IS permission model and risks
- Designate the org-owners who handle rare removals
- Add the boundaries above to the Moderation Policy as a permissions section
- Make the permission changes
- Edit moderation onboarding
Assisted by: Claude Opus
- 主要語言
- JavaScript
- 星號
- 202
- 分支
- 183
- 平均合併
- 13 天 12 小時
- 30 天內合併 PR
- 2
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
nodejs/admin 的其他 Issue
-
難度 1/5 1 小時以內 新手友好度 90/100
-
tsc-agenda
難度 5/5 一週以上 新手友好度 30/100
-
難度 5/5 一週以上 新手友好度 35/100
-
難度 5/5 一週以上 新手友好度 35/100
-
難度 1/5 1 小時以內 新手友好度 35/100
相似的 Issue
-
area/install-update comp/cli comp/desktop P3 sweeper:risk-compatibility type/bug
難度 2/5 1-3 小時 新手友好度 86/100
NousResearch/hermes-agent#122386 · 1 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 74/100
-
security
難度 2/5 1-3 小時 新手友好度 72/100
IBM/node-sdk-core#373 ·
-
docs web/
難度 2/5 1-3 小時 新手友好度 68/100
-
難度 2/5 1-3 小時 新手友好度 65/100