[Server] Validate `Host` and `Origin` independently in `DnsRebindingProtectionMiddleware`
維護者通常 1 天內回覆
評估
研究方向
Start by locating DnsRebindingProtectionMiddleware and reading its current handling of the Host and Origin headers. The issue raises two alternative designs and does not identify files or tests; first determine the project’s existing middleware and test conventions. Done means validating Host on every request and, if present, Origin separately with its own allowlist, including scheme and port.
由索引模型根據 Issue 內容生成。
描述
The current DnsRebindingProtectionMiddleware handles Host and Origin as alternatives:
- If an
Originheader is present, only its hostname is checked. - Otherwise, the
Hostheader is checked. - Both values are checked against the same
allowedHostslist.
This causes several issues:
- An invalid
Hostheader is not rejected when an allowedOriginheader is present. HostandOriginrepresent different parties:Hostidentifies the target MCP server, whileOriginidentifies the web origin initiating the request. They commonly have different values and therefore require separate allowlists.- Origin validation is reduced to the hostname. This makes it impossible to distinguish origins by scheme or port, even though those are part of the web-origin tuple.
Would it make sense to either:
- Split this into separate Host and Origin validation middleware; or
- Extend
DnsRebindingProtectionMiddlewarewith separateallowedHostsandallowedOriginsoptions, validatingHoston every request and additionally validatingOriginwhenever it is present?
I would be happy to submit a pull request if this direction is acceptable.
- 主要語言
- PHP
- 星號
- 1.6k
- 分支
- 180
- 平均合併
- 3 天 12 分鐘
- 30 天內合併 PR
- 44
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
modelcontextprotocol/php-sdk 的其他 Issue
-
[Server] Handler type uses bare Closure, hard to decorate RegistryInterface under strict PHPStan未關閉Server
難度 1/5 1 小時以內 新手友好度 78/100
modelcontextprotocol/php-sdk#468 · 2 則留言 ·
維護者通常 1 天內回覆
-
Builder::build() silently skips configured file-based discovery when symfony/finder is missing — should fail loudly可能已有人在做 @ousamabenyounes 於 56 天前認領。 未關閉needs confirmation needs maintainer action Server
難度 2/5 1-3 小時 新手友好度 68/100
modelcontextprotocol/php-sdk#398 · 1 個 reaction ·
維護者通常 1 天內回覆
-
enhancement
難度 2/5 1-3 小時 新手友好度 68/100
modelcontextprotocol/php-sdk#370 ·
維護者通常 1 天內回覆
-
enhancement
難度 4/5 3-5 天 新手友好度 52/100
modelcontextprotocol/php-sdk#587 ·
維護者通常 1 天內回覆
-
bug
難度 3/5 半天 新手友好度 60/100
modelcontextprotocol/php-sdk#586 · 2 則留言 ·
維護者通常 1 天內回覆
查看 modelcontextprotocol/php-sdk 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 62/100
維護者通常 1 天內回覆
-
documentation
難度 2/5 1-3 小時 新手友好度 62/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
humanmade/publication-checklist#73 · 1 則留言 ·
-
Do not throw `WordPress.Security.EscapeOutput.OutputNotEscaped` on `apply_shortcodes()`可能已有人在做 @tbradsha 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 75/100
-
難度 2/5 1-3 小時 新手友好度 62/100
landsman/adminer-desktop#120 ·
維護者通常 1 天內回覆