Hacktoberfest 2026：維護者為十月標記出來的 issue，仍然開放、適合新手。 瀏覽 Hacktoberfest issue

Signed copies in Workloads/ and wsl-comfort/ are stale and no longer verify

未關閉
  • 哪裡不對？
#137 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
48/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
powershell
領域
ci-cd, release

研究方向

Start with src/tools/check-signed-drift.ps1 and compare its reported roots with Workloads/, wsl-comfort/, and windows-dev-config/. Run Get-AuthenticodeSignature over the release copies and inspect the existing sign pipeline and the history around #105, #107, and #126. Done means the affected copies are current, retain verifiable signatures, and the validation pass catches signature failures.

由索引模型根據 Issue 內容生成。

描述

I ran Get-AuthenticodeSignature over the signed release copies, and most of the files under Workloads/ and wsl-comfort/ come back NotSigned. The windows-dev-config/ copies are fine.

Windows 11 Pro 26H2 (build 26300.9550), pwsh 7.6.6, Get-ChildItem <root> -Recurse -Filter *.ps1 | Get-AuthenticodeSignature | Group-Object Status on a git archive:

Root ff7a538 (before #105) 231c59b (current main)
windows-dev-config/ 24 × Valid 32 × Valid
Workloads/ 12 × Valid, 5 × HashMismatch 1 × Valid, 16 × NotSigned, 1 × HashMismatch
wsl-comfort/ 1 × Valid 1 × NotSigned

I think this comes from #105. It marked the signed copies -text, so git checks them out byte for byte. windows-dev-config/ was re-committed as raw signed bytes in #107 right after, but the files under Workloads/ and wsl-comfort/ were committed back when *.ps1 text eol=crlf applied (#26), so their blobs have LF. Before #105, checkout turned that back into the CRLF the files were signed with. Now it doesn't, and the signatures don't match. The ZIP from GitHub has the same bytes.

The only Valid file under Workloads/ is winui/setup.ps1, which is new in #125 and gets signed together with windows-dev-config/ (#126, #130, #132). The other sixteen haven't changed since before #105. winui/install.ps1 is the odd one: it was re-signed, it has CRLF and a signature block, its body matches src/ after normalization, and it still comes back HashMismatch. The five shims that were HashMismatch before #105 looked the same.

I tried putting the CR back. That alone makes 13 of the 17 Valid again, signed by Microsoft Corporation: dotnet, go, java, powershell, rust, sql, the six in _common/ and wsl-comfort/install.ps1. php, python, typescript and winforms become HashMismatch instead, so those four, winui/install.ps1 and wsl-comfort/install.ps1 need to go through signing again. I guess you'd rather just run the sign pipeline over those two roots anyway, but if a PR that puts the CR back in the twelve is useful in the meantime, I have one ready.

The practical effect: the README points people at .\Workloads\<id>\install.ps1 and .\wsl-comfort\install.ps1. When the download and the extraction keep the mark of the web, under RemoteSigned PowerShell refuses .\Workloads\python\install.ps1 with "is not digitally signed". dev-config.ps1, which still verifies, gets the publisher prompt instead, or just runs if Microsoft is already a trusted publisher. From a clone there is no mark of the web, so the same python script passes the RemoteSigned check and can run as an unsigned script. Under AllSigned the copies without a valid signature are refused everywhere.

wsl-comfort/ is also out of date compared to src/. The root comfort-shell-bootstrap.sh still has alias ls="eza --icons" (#79, fixed in src/ by #80), and install.ps1 and readme.md are behind since #120. src/tools/check-signed-drift.ps1 lists all three, plus Workloads/winappcli/* from #106, which has never had a signed release copy committed. The drift check strips the signature block before comparing, so it can't catch the signature problem. A Get-AuthenticodeSignature pass over the three roots in CI would, which I think is what #34 asked about.

If that sign run also commits the raw bytes like #107 and checks the signatures afterwards, it should cover all of this. Happy to help test.

主要語言
PowerShell
星號
2.9k
分支
202
平均合併
18 小時 49 分鐘
30 天內合併 PR
24

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

microsoft/WindowsDeveloperConfig 的其他 Issue

查看 microsoft/WindowsDeveloperConfig 的全部 Issue

相似的 Issue

更多 DevOps Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。