7.1 regression: comparing a recursive `-?` mapped type is quadratic in the number of properties and hits TS2589 (since typescript-go#4820)

未關閉
  • 哪裡不對？
#64,950 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
48/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
go, typescript
領域
compilers, performance

研究方向

Start by reading the variance computation change in microsoft/typescript-go#4820, then reproduce the issue with the supplied one-file repro and tsc -p . --singleThreaded --extendedDiagnostics. Compare instantiation counts for the last good and first bad builds, focusing on the recursive Builder interface, its -? mapped type, and changing S | K argument. Done means the comparison stays near linear in property count and the 500-property repro succeeds without TS2589.

由索引模型根據 Issue 內容生成。

描述

Bug
🔎 Search Terms

variance, TS2589, excessively deep, instantiation count, mapped type, -?, quadratic, 7.1 regression

🕗 Version & Regression Information
  • Last good: 7.1.0-dev.20260805.1 (gitHead 12318e599d)
  • First bad: 7.1.0-dev.20260806.1 (gitHead 86cc4767d4)
  • That range is one commit: microsoft/typescript-go#4820, "Order variance computation by associated type symbol".
  • Still failing on 7.1.0-beta and 7.1.0-dev.20261024.1.
  • 7.0.2 accepts the code.

Same commit as #64891 and #64930, but this one is about performance: the comparison finishes with a correct result
for small types, it just costs quadratically more instantiations, and on real types it hits the 5M cap.

⏯ Playground Link

The 7.1 builds aren't available in the Playground. CLI repro: one file in an empty directory, tsc -p . --singleThreaded --extendedDiagnostics.

tsconfig.json

{ "compilerOptions": { "strict": true, "noEmit": true, "types": [] }, "files": ["repro.ts"] }
💻 Code
type D = '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9'
type Entity = Record<`f${'0' | '1' | '2' | '3' | '4'}${D}${D}`, string> // 500 properties

interface Method<T, K extends keyof T, S> {
	(): Builder<T, S | K>
}
type Builder<T, S = never> = { [K in keyof T]-?: Method<T, K, S> }

declare const builder: Builder<Entity>
export const widened: Builder<Entity & object> = builder
🙁 Actual behavior
repro.ts(10,14): error TS2589: Type instantiation is excessively deep and possibly infinite.
Instantiations: 5003892   Check time: 79 s
🙂 Expected behavior

No error, as in 7.0.2 and 7.1.0-dev.20260805.1: about 9k instantiations, 0.04 s check time.

Additional information about the issue

With 100 properties (Record<`f${D}${D}`, string>) there is no error, but the count goes from 5,105 to 256,939
instantiations. It grows with the square of the property count: about 66k at 50 properties, 1M at 200 and the 5M cap
near 460.

build 100 props: instantiations 500 props
7.0.2 5,105 9,105, ok
7.1.0-dev.20260805.1 (12318e599d) 5,105 9,105, ok
7.1.0-dev.20260806.1 (86cc4767d4) 256,939 TS2589
7.1.0-dev.20261024.1 258,143 TS2589

All three of these are needed for the quadratic count; removing any one brings it back to linear:

  • the -? modifier on the homomorphic mapped type;
  • Method as a generic interface that references Builder again (with an inline () => Builder<T, S | K> both
    7.0.2 and 7.1 are quadratic, so the regression is in how the interface's variance gets computed);
  • a type argument that actually changes, here S | K (with Builder<T, S> it stays linear).

The target also has to be a different but equivalent instantiation (Entity & object); a structurally identical
mapped copy of Entity does not trigger it.

Real-world impact: this is a reduced form of a fluent "selection builder" type from our library, whose
entity types resolve through UnionToIntersection<E> & object, so every selector is compared against
Builder<E & object>. On a ~2,100-file app under 7.1:

  • TS2589 appears on ordinary selector call sites, and the callbacks' destructured parameters cascade into TS7031/TS7006.
  • The depth error leaves the checker's caches in a bad state, so a later file that checks cleanly on its own reports
    TS2339 (members missing on the builder's result type). The error count depends on --checkers and on which files
    share a checker (0 to 77).
  • The project checks --singleThreaded in 25 s / 2.6 GB on 7.1.0-dev.20260805.1; on 7.1.0-dev.20260930.4 the
    same run was OOM-killed at an 18 GB cap, and with default checkers it reached 24 GB before being killed.
主要語言
Go
星號
112k
分支
15.4k
平均合併
2 天 21 小時
30 天內合併 PR
126

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

microsoft/TypeScript 的其他 Issue

查看 microsoft/TypeScript 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。