File changed on disk with a content-mapped or `.d.ts` extension never triggers workspace/diagnostic/refresh

未關閉
  • 哪裡不對？
#64,943 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@mrlubos 已經在處理了。

開始於 2026年10月23日。

  • #64944 來自 @mrlubos —— 未關閉

評估

難度
3/5
預估耗時
1-2 天
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
javascript, node.js, typescript
領域
backend, devtools, testing-qa

研究方向

Start with the change in #64159 and trace Session.DidChangeWatchedFiles, path.Extension(), and the content mapper extension check described in the issue. Use the linked repro repository with npm install && npm run repro to compare changes to dep.ts, shape.data, and an open shape.data file. Done when disk changes to mapped files and .d.ts files trigger diagnostic refreshes.

由索引模型根據 Issue 內容生成。

描述

🔎 Search Terms

"content mapper", "contentMappers", "workspace/diagnostic/refresh", "didChangeWatchedFiles", "isRelevantExtension", "stale diagnostics", "restart TS server", ".d.ts"

🕗 Version & Regression Information
  • This changed in #64159, which switched Session.DidChangeWatchedFiles from taking everything after the last dot to path.Extension(). Seen on [email protected].
⏯ Playground Link

No response

💻 Code

Repro: https://github.com/mrlubos/ts-content-mapper-refresh (npm install && npm run repro)

// tsconfig.json
{ "compilerOptions": { "module": "nodenext", "strict": true, "noEmit": true },
  "contentMappers": [{ "package": "toy-mapper", "extensions": [".data"] }] }

// index.ts. toy-mapper turns each `name: type` line of shape.data into a member of `Data`.
import type { Dep } from './dep.js';
import type { Data } from './shape.data';
declare const dep: Dep;
declare const data: Data;
export const fromTs = dep.age;     // error until `age` is added to dep.ts
export const fromData = data.age;  // error until `age: number` is added to shape.data
🙁 Actual behavior

After shape.data changes on disk (written by another process, with the editor sending workspace/didChangeWatchedFiles), the server never sends workspace/diagnostic/refresh. In VS Code the error on data.age stays until "TypeScript: Restart TS Server". The server already has the right answer: a textDocument/diagnostic request made by hand returns no errors. npm run repro drives tsc --lsp as VS Code does and prints:

  1. dep.ts changed on disk, refresh requests: 1
  2. shape.data changed on disk, refresh requests: 0
    errors when pulled by hand: []
  3. shape.data edited while open, refresh requests: 1
🙂 Expected behavior

A change on disk to a file a registered content mapper handles should refresh diagnostics the way a change to a .ts file does, since it changes the program. This matters most when a tool regenerates the mapped file, for example a dev server writing an API description on each reload, because the editor never has that file open.

Additional information about the issue

path.Extension() returns only the extensions TypeScript reads itself. For shape.data it returns "", so the path is treated as a possible directory: DirectoryExists is false and the change is dropped. The check against the extensions a project's contentMappers register is in the else branch, which a mapped extension never reaches.

The same change breaks .d.ts files: path.Extension() returns .d.ts, which isRelevantExtension does not list, so a declaration file changed on disk does not refresh diagnostics either.

A workaround for mapped files is to keep the file open in an editor tab, so VS Code reloads it and sends didChange.

主要語言
Go
星號
112k
分支
15.4k
平均合併
3 天 5 小時
30 天內合併 PR
149

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

microsoft/TypeScript 的其他 Issue

查看 microsoft/TypeScript 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。