permission_check fails on fork PRs before it checks anything (checkout v7 refuses the head ref)
還沒有人認領這個 Issue。
評估
研究方向
先閱讀 init-svc-executable-permissions.yml,然後比較 docker-mod-builder.yml 中的 checkout 步驟。追蹤 issue 中描述的權限檢查和 git trees API 方法;完成的標準是 fork-head 權限檢查能夠正常運作,同時不使用不安全的 checkout,也不改變 pull_request_target 的安全性,包括文件中記錄的 fork 和內部情況。
由索引模型根據 Issue 內容生成。
描述
init-svc-executable-permissions.yml fails on a fork pull request that touches run, finish, check or root/migrations/*. The job stops before any file is read, because actions/checkout@v7.0.1 refuses pull_request.head.sha in a pull_request_target workflow.
PR #190 shows it: https://github.com/linuxserver/docker-baseimage-selkies/actions/runs/33459741080/job/99707212121
The checkout step ends with:
##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
"Check Permissions" is then skipped and the job fails. On that head SHA (a5272e08) all 13 run/finish files are 100755, so the check would have passed.
The switch to checkout 7 reached v1 with 6c9815b8 on 2026-07-03; the first fork run after that is from 2026-07-06. Since then 45 fork-head runs across linuxserver have failed and 7 internal-head runs have passed. After the switch and before that first fork run, docker-sabnzbd run 28709064096 (2026-07-04) passed: **** All perms look good ****. Twelve open fork pull requests carry a red permission_check; three more are green from before the switch.
f3577570 pinned the step to the head SHA because the check needs the PR's own files. The file modes can be read without a checkout: the git trees API on the base repository reaches the fork head through refs/pull/N/head, so the job can flag any matching blob that is not 100755 without fetching fork code. At a5272e08 it returns truncated: false, 151 entries, 13 of them run/finish blobs, all 100755. That leaves pull_request_target and the pinned ref untouched, with no allow-unsafe-pr-checkout. The same checkout step sits in docker-mod-builder.yml, which handles CR_PAT and DOCKERPASS.
- 主要語言
- 沒有語言資料
- 星號
- 6
- 分支
- 1
- 平均合併
- 11 小時 55 分鐘
- 30 天內合併 PR
- 3
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
相似的 Issue
-
Solved site promotion gate fails on runner PHP patch drift (expects 8.2.33, runner installs 8.2.34) 未關閉
難度 2/5 1-3 小時 新手友好度 75/100
Automattic/blocks-engine#2161 ·
-
難度 1/5 1 小時以內 新手友好度 60/100
github/gh-aw-mcpg#13748 ·
-
agentic-workflows
難度 2/5 1-3 小時 新手友好度 65/100
-
難度 2/5 1-3 小時 新手友好度 70/100
personalrobotics/tsr#128 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
Azure/azure-functions-docker#1257 ·