LINBO hardware groups have no school ownership: LinboConfigManager ignores its school argument
還沒有人認領這個 Issue。
評估
研究方向
Examine linuxmusterTools/linbo/config.py to understand the LinboConfigManager class and how it currently ignores the school argument. Look at the file paths in /srv/linbo/ to see the flat structure. Check the linuxmuster-api routers_v1/linbo.py for the TODO comment. Determine if LINBO's TFTP/PXE boot process requires a flat layout or can support per-school directories. The goal is to modify the config manager to respect the school argument, potentially changing file paths and updating enumeration logic.
由索引模型根據 Issue 內容生成。
描述
What we ran into
LinboConfigManager accepts a school argument and then never uses it, so the LINBO hardware groups are one flat, server-wide set rather than per-school data.
In usr/lib/python3/dist-packages/linuxmusterTools/linbo/config.py (branch lmn74):
LINBO_PATH = '/srv/linbo'
class LinboConfigManager:
def __init__(self, school='default-school'):
self.school = school
...
def _list_group_ids(self):
group_ids = []
for config in sorted(glob(os.path.join(LINBO_PATH, 'start.conf.*'))):
...
self.school is stored and never read; enumeration globs LINBO_PATH directly. The same holds for reading and writing a group's start.conf — every path is /srv/linbo/start.conf.<id>, with no school component.
linuxmuster-api already documents this as the blocker for opening the routes up, in routers_v1/linbo.py:
# TODO: startconfs/configs (this section) stay G-only on purpose — group_id has
# no school ownership anywhere in linuxmusterTools.linbo (raw, flat, global
# /srv/linbo/start.conf.<id>), same gap as the legacy lmn_linbo4 plugin. Opening
# to school-admins needs real per-school ownership in lmntools first, not a
# quick RoleChecker flip.
So this issue is just the concrete request behind that TODO, filed where the ownership would have to live.
Why it matters to us
We build the LINBO UI in edulution-ui. It has a school selector, and on a multi-school server a user reasonably reads that selector as scoping the hardware groups they are editing. It does not — a change to a group applies to every school on the server.
Passing school through to the API endpoints would not have changed that; it would only have made our code look school-correct while upstream ignored the value. So we shipped an explicit notice in the UI instead, telling the user the groups are server-wide wherever a server runs more than one school. That is the honest behaviour for today's data model, but it is a workaround for a limitation, not the outcome we want.
What would help
Real per-school ownership of the LINBO group configuration in linuxmusterTools.linbo, so that LinboConfigManager(school=...) enumerates, reads and writes only that school's groups. Concretely, the two questions we cannot answer from the outside:
- Is a per-school layout on the table at all — e.g.
/srv/linbo/<school>/start.conf.<id>, or a school prefix in the group id — or is the flat set a deliberate property of how LINBO serves clients over TFTP/PXE, where a single boot path has to resolve without knowing a school? - If a per-school layout is possible, what would the migration look like for existing installations, and would
school='default-school'keep meaning "the flat set" for compatibility?
Happy to help with whichever direction you prefer — including doing the work, if you can say which layout you would accept. If the answer is that the flat set is intentional and permanent, that is a useful answer too: we would then document the server-wide scope as the designed behaviour rather than carry it as a known gap.
Versions
linuxmuster-toolsbranchlmn74,linuxmusterTools/linbo/config.pylinuxmuster-apibranchlmn74,routers_v1/linbo.py
- 主要語言
- Python
- 星號
- 3
- 分支
- 5
- PR 合併指標
- 30 天內沒有已合併 PR
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
linuxmuster/linuxmuster-tools 的其他 Issue
-
難度 5/5 一週以上 新手友好度 20/100
查看 linuxmuster/linuxmuster-tools 的全部 Issue
相似的 Issue
-
difficulty:2 enhancement good first issue
難度 2/5 1-3 小時 新手友好度 85/100
MakazhanAlpamys/Soup#2309 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 85/100
google-deepmind/tapnet#173 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
-
難度 2/5 1-3 小時 新手友好度 65/100
Netcracker/qubership-ai-packages#203 ·
維護者通常 1 天內回覆
-
PAC Wording
難度 1/5 1 小時以內 新手友好度 72/100
維護者通常 1 天內回覆