Measure the payload copy in the engine request, and share the block if it shows
維護者通常 6 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 48/100
- Issue 類型
- 功能
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- rust
- 領域
- performance
研究方向
Read crates/blockchain/src/beacon_engine.rs and the changes in lambdaclass/ethlambda#755 to understand NewPayloadRequest::into_owned and the engine import phase metric. Measure request construction on a live node with an execution client for typical and transaction-heavy blocks, comparing it with the roughly 157 ms transition time cited in the issue. If the copy is material, apply the outlined Arc ownership approach; done means the measurement is reported and any resulting change avoids the actor-thread copy while preserving the block for on_block_speculative.
由索引模型根據 Issue 內容生成。
描述
Since lambdaclass/ethlambda#755, a pre-gloas beacon import with an execution client sends engine_newPayloadV4 from a spawned task while the chain actor computes the block's state transition. The task cannot borrow the block, so NewPayloadRequest::into_owned (crates/blockchain/src/beacon_engine.rs) clones the block's ExecutionPayload, transactions included, on the actor thread before the request is spawned. Three automated reviewers raised the copy across two review rounds of that PR.
Its cost has not been measured, neither typically nor for a transaction-heavy worst case, so it is not known how it compares with the transition it overlaps (~157 ms at the docs' p50). Since #755 the engine import phase (lean_block_import_phase_seconds{phase="engine"}) includes building the request, so the copy is visible there on a live node: the phase's floor, for blocks whose answer arrived before the transition finished, is roughly the request construction.
Measuring it was out of scope for #755, since it needs a live node with an execution client.
What a fix would look like, if the floor is material:
- Move the block into an
Arcfor the duration of the question. - Have the task build the request from its clone, so nothing is copied on the actor.
- Take the block back with
Arc::unwrap_or_clonebeforeon_block_speculative. The task has finished by then, so this does not clone in practice.
OwnedNewPayloadRequest and into_owned would then go away.
- 主要語言
- Rust
- 星號
- 86
- 分支
- 34
- 平均合併
- 9 天 20 小時
- 30 天內合併 PR
- 77
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
lambdaclass/ethlambda 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 76/100
lambdaclass/ethlambda#850 ·
維護者通常 6 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
lambdaclass/ethlambda#777 · 1 個 reaction ·
維護者通常 6 天內回覆
-
Run all gossip validation tests可能重新可做 @dicethedev 於 9 天前認領,目前沒有進行中的 PR。 未關閉
難度 2/5 1-3 小時 新手友好度 62/100
lambdaclass/ethlambda#725 · 2 則留言 ·
維護者通常 6 天內回覆
-
Handle malformed DB data可能重新可做 @dicethedev 於 115 天前認領,目前沒有進行中的 PR。 未關閉
難度 2/5 1-3 小時 新手友好度 76/100
lambdaclass/ethlambda#529 · 4 則留言 ·
維護者通常 6 天內回覆
-
Document architectural choices可能重新可做 @dicethedev 於 115 天前認領,目前沒有進行中的 PR。 未關閉
難度 2/5 1-3 小時 新手友好度 68/100
lambdaclass/ethlambda#521 · 2 則留言 ·
維護者通常 6 天內回覆
查看 lambdaclass/ethlambda 的全部 Issue
相似的 Issue
-
難度 1/5 1 小時以內 新手友好度 88/100
bytecodealliance/wrpc#1785 ·
維護者通常 1 天內回覆
-
2 advisory ignore entries no longer match anything (`quick-xml` already patched in `Cargo.lock`)未關閉
難度 1/5 1 小時以內 新手友好度 85/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
longbridge/nsh#2758 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 84/100
antithesishq/bombadil#473 ·
維護者通常 2 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 72/100
libracoder/kiri#669 ·
維護者通常 1 天內回覆