String wrapping is not idempotent
還沒有人認領這個 Issue。
評估
研究方向
在 Java 17 上使用 google-java-format 1.15.0 或 1.16.0 的 all-deps JAR,透過提供的 TestFormat.java 範例重現此問題。重複執行格式化,並比較每次執行後 switch-expression 字串的配置。當格式化未變更的檔案在之後的每次執行中都產生完全相同的輸出時,即表示完成。
由索引模型根據 Issue 內容生成。
描述
This happened with the all deps jar from github, for both versions 1.15.0 and 1.16.0.
$ java --version
openjdk 17.0.6 2023-01-17
OpenJDK Runtime Environment (build 17.0.6+10)
OpenJDK 64-Bit Server VM (build 17.0.6+10, mixed mode)
Example code is
package com.example;
public class TestFormat {
public void main() {
var value = 1;
var responseMessage =
switch (value) {
case 1 -> "This is a long string;This is a long string;This is a long string;This is a long string;This is a long string;This is a long string;This is a long string;";
case 2 -> "some short string";
case 3 -> "some medium string some medium string some medium string some medium string";
};
}
}
Now these strings in the switch statement will be different formatted depending on how often I call google java format.
Weirdly enough, the cosium maven plugin (gjf v1.15.0) does not change the strings in this example at all. This would be preferable for me, but mostly I want a consistent format.
## executing preview only
$ java -jar /home/dev/dev/libs/google-java-format-1.15.0-all-deps.jar Testformat.java
package com.example;
public class TestFormat {
public void main() {
var value = 1;
var responseMessage =
switch (value) {
case 1 -> "This is a long string;This is a long string;This is a long string;This is a"
+ " long string;This is a long string;This is a long string;This is a long"
+ " string;";
case 2 -> "some short string";
case 3 -> "some medium string some medium string some medium string some medium string";
};
}
}
## applying changes
$ java -jar /home/dev/dev/libs/google-java-format-1.15.0-all-deps.jar -r Testformat.java
## executing preview only
$ java -jar /home/dev/dev/libs/google-java-format-1.15.0-all-deps.jar Testformat.java
package com.example;
public class TestFormat {
public void main() {
var value = 1;
var responseMessage =
switch (value) {
case 1 -> "This is a long string;This is a long string;This is a long string;This is a"
+ " long string;This is a long string;This is a long string;This is a long"
+ " string;";
case 2 -> "some short string";
case 3 -> "some medium string some medium string some medium string some medium string";
};
}
}
The expectation would be that once I format a file every future format call would not change anything anymore as long as nothing was changed on the file.
- 主要語言
- Java
- 星號
- 6.2k
- 分支
- 936
- 平均合併
- 6 分鐘
- 30 天內合併 PR
- 3
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
google/google-java-format 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 72/100
google/google-java-format#1094 · 1 則留言 ·
-
難度 5/5 一週以上 新手友好度 15/100
google/google-java-format#1450 · 1 個 reaction ·
-
難度 4/5 3-5 天 新手友好度 55/100
google/google-java-format#1439 · 1 則留言 ·
-
難度 3/5 1-2 天 新手友好度 62/100
google/google-java-format#1436 · 2 則留言 ·
-
難度 3/5 1-2 天 新手友好度 48/100
google/google-java-format#1428 · 4 則留言 ·
查看 google/google-java-format 的全部 Issue
相似的 Issue
-
area/plugin
難度 2/5 1-3 小時 新手友好度 75/100
kestra-io/plugin-kestra#190 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
google-ai-edge/LiteRT-LM#3739 ·
-
bug
難度 2/5 1-3 小時 新手友好度 75/100
-
難度 2/5 1-3 小時 新手友好度 75/100
integra-team-red/meet-map#249 ·
-
[Studio][Bug] Cancelled create-user dialog keeps the password and admin switch for the next attempt 未關閉
難度 2/5 1-3 小時 新手友好度 75/100
apache/rocketmq-dashboard#5064 ·