Hacktoberfest 2026：維護者為十月標記出來的 issue，仍然開放、適合新手。 瀏覽 Hacktoberfest issue

Stack panel says a pull request is queued when it has no queue entry

未關閉
  • 哪裡不對？
#503 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
68/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
github, go
領域
api, cli

研究方向

先查看 stack 面板狀態以及 pullRequest 查詢欄位 isInMergeQueue 和 mergeQueueEntry{ position }；透過將面板與合併佇列頁面和 API 回應進行比較，重現兩個 PR 的情況。完成標準是：未入列的上方 pull request 不再顯示入列相關文字或 Remove from queue 動作，而現有的正確徽章仍維持正確。

由索引模型根據 Issue 內容生成。

描述

Summary

On a stacked pull request that is not in the merge queue, the stack panel says it is, and offers to remove it. The badges in the same panel report the state correctly, so the panel contradicts itself.

Evidence

Stack main ← #101 ← #102. After Enqueue stack (2), only #101 is admitted. The page of #102 then shows:

  • the heading "Queued to merge…"
  • "This pull request is next up in the merge queue."
  • a "Remove from queue" button
  • badges #102 Ready and #101 Queued, which are correct
Image

The merge queue page for the same branch shows 1 Queued and lists only #101:

Image

The API agrees with the queue page, not with the heading:

mergeQueue(branch:"main").entries.totalCount = 1
mergeQueue(branch:"main").entries.nodes      = [{ position: 1, pullRequest: #101 }]

#101   isInMergeQueue true    position 1
#102   isInMergeQueue false   mergeQueueEntry null

#102 reported isInMergeQueue=false at every sample across the whole landing.

Expected

A stacked pull request with no queue entry should not be described as queued:

  • do not head the panel "Queued to merge…" on a pull request that is not queued;
  • do not say "This pull request is next up in the merge queue" when isInMergeQueue is false. If the intent is that this layer goes after the one below it, say that. It is a statement about the stack, not about queue membership;
  • do not offer "Remove from queue" for a pull request with no mergeQueueEntry. The button does not say whether it would remove the layer below, which would be destructive.

Actual

The heading, the sentence and the button all claim queue membership that the API denies, while the badges in the same panel report it correctly.

Environment

  • gh 2.100.0, gh stack v0.0.8
  • Trunk ruleset: 
    merge_queue:   grouping_strategy HEADGREEN, merge_method REBASE,
               max_entries_to_build 8, max_entries_to_merge 8,
               min_entries_to_merge 1, min_entries_to_merge_wait_minutes 5,
               check_response_timeout_minutes 40
pull_request:  allowed_merge_methods ["rebase"], required_approving_review_count 1,
               require_last_push_approval false, dismiss_stale_reviews_on_push false
  • delete_branch_on_merge: true, allow_auto_merge: false

Reproduction

  1. Protect a trunk with a merge queue. Run gh stack link <bottom> <top> and get both pull requests approved and green.
  2. Press Enqueue stack (2).
  3. Open the top pull request and compare its panel against the branch's merge queue page and against pullRequest{ isInMergeQueue mergeQueueEntry{ position } }.

Related

  • #174 — why the upper layer is out of the queue in the first place
  • #172 — "'Merge stack' appears to enqueue only the bottom PR"
  • #502 — the wording matters most there, because the rewrite forces a manual re-enqueue and this panel gives no sign of it
主要語言
Go
星號
1.5k
分支
73
平均合併
13 小時 24 分鐘
30 天內合併 PR
3

環境準備

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

github/gh-stack 的其他 Issue

查看 github/gh-stack 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。