gh stack sync reports success after its atomic push fails
還沒有人認領這個 Issue。
評估
研究方向
從 gh stack sync 命令開始，追蹤原子分支推送結果。驗證失敗的推送會停止 PR 同步、不會產生 Branches synced 回執，並返回非零值；為重現的三個 PR rebase 情境新增或更新測試覆蓋率。
由索引模型根據 Issue 內容生成。
描述
Reproduction
Start with an existing three-PR stack whose local branches were rebased and therefore require force pushes, then run:
$ gh stack sync --remote origin
✓ Fetched latest dev from origin
✓ Trunk dev is already up to date
Pushing 3 branches to origin...
⚠ Push failed — branches may need force push after rebase
Run `gh stack push` to push with --force-with-lease.
Syncing PRs ...
✓ PR #4440 (...) — Open
✓ PR #4441 (...) — Open
✓ PR #4444 (...) — Open
⚠ Cannot create stack: Pull requests must form a stack, where each PR's base ref is the previous PR's head ref
Each PR's base branch must match the previous PR's head branch.
✓ Branches synced
Stacked on dev (a80f5ad)
$ echo $?
0
All three remote branch SHAs remained unchanged. The local stack was therefore not published, but sync continued into PR synchronization, printed a success receipt, and exited zero.
Expected
gh stack sync exits nonzero immediately when its atomic branch push fails. It does not attempt PR synchronization or print Branches synced, because the remote stack cannot match local state until the branch refs are updated.
Environment
gh-stackv0.1.0gh2.96.0- git 2.50.1
- macOS arm64
Related
#346 covers suppressed git-hook output during gh stack push. This report is about sync swallowing the failed-push status and returning a false success.
- 主要語言
- Go
- 星號
- 1.5k
- 分支
- 73
- 平均合併
- 1 天 8 小時
- 30 天內合併 PR
- 7
貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
github/gh-stack 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 85/100
-
難度 1/5 1 小時以內 新手友好度 92/100
-
feature request topic: cli - general
難度 2/5 1-3 小時 新手友好度 68/100
-
feature request topic: auto-merge
難度 2/5 1-3 小時 新手友好度 68/100
-
bug topic: docs
難度 1/5 1 小時以內 新手友好度 68/100
相似的 Issue
-
area/dev-productivity area/disaster-recovery area/ipcei kind/enhancement
難度 2/5 1-3 小時 新手友好度 70/100
-
難度 1/5 1 小時以內 新手友好度 85/100
-
難度 2/5 1-3 小時 新手友好度 75/100
-
kind/bug status/0-triage
難度 2/5 1-3 小時 新手友好度 75/100
-
🤔 refinement needed
難度 2/5 1-3 小時 新手友好度 75/100
equinor/radix-operator#1979 ·