java/local-shadows-field: a local declared inside a lambda or anonymous class body is not reported

未關閉
  • 哪裡不對？
#22,969 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
半天
新手友好度
55/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
java
領域
devtools

研究方向

The likely cause is the shadows predicate in Shadowing.qll, which requires the local's callable to be declared by the class that owns the field (method.getDeclaringType() = c). Start by running the three samples (ShadowSeed, ShadowVariant, ShadowControl) against java/local-shadows-field and confirming only the seed fires. Done when the local inside the lambda and inside the anonymous class is reported, and the seed case still is.

由索引模型根據 Issue 內容生成。

描述

Description of the issue

The query reports the local String[] arr in ShadowSeed.getArr(), which has the same name as the field the method reads as this.arr. Declare the same local inside a lambda in that method (ShadowVariant) or inside an anonymous class (ShadowControl) and nothing is reported, though it still shadows the field and the method still reads this.arr.

Probably the shadows predicate in Shadowing.qll: it requires the local's callable to be declared by the class that declares the field (method.getDeclaringType() = c). Inside a lambda the callable is the lambda's own method, and inside an anonymous class it's that class's method.

Query: java/local-shadows-field (codeql/java-queries 1.1.10)

CodeQL CLI: 2.27.2

Code samples

seed/ShadowSeed.java:

public class ShadowSeed {
    String[] arr;
    String[] getArr() {
        String[] arr;                      // shadows the field; the query fires here
        return this.arr;
    }
}

variant/ShadowVariant.java:

public class ShadowVariant {
    String[] arr;
    String[] getArr() {
        Runnable r = () -> {
            String[] arr;                  // the same local inside a lambda body; not reported
        };
        r.run();
        return this.arr;
    }
}

control/ShadowControl.java:

public class ShadowControl {
    String[] arr;
    String[] getArr() {
        Runnable r = new Runnable() {
            public void run() {
                String[] arr;              // inside an anonymous class; not reported either
            }
        };
        r.run();
        return this.arr;
    }
}

How to reproduce

codeql database create db --language=java --build-mode=none \
    --source-root=<one directory> --overwrite
codeql database analyze db \
    codeql/java-queries:codeql-suites/java-security-and-quality.qls \
    --format=csv --output=out.csv
# one database per directory

Expected result

"Potentially confusing name: method ... also refers to field arr (as this.arr)" on the local in ShadowVariant.java (line 5) and in ShadowControl.java (line 6), as on ShadowSeed.java (line 4).

Output of the commands above:

### CodeQL 2.27.2  query: java/local-shadows-field
### suite: java-security-and-quality.qls, --build-mode=none, per-file isolated databases
### extraction JDK: openjdk version "21.0.11" 2026-04-21 LTS

--- SEED -- expected: query fires (seed/)
"Possible confusion of local and field","A method in which a variable is declared with the same name as a fiel

--- VARIANT -- expected: query fires, actual: not reported (the bug) (variant/)
    (query reported nothing)

--- CONTROL -- the same construct in an anonymous class, expected: query fires (control/)
    (query reported nothing)
主要語言
CodeQL
星號
10.3k
分支
2.1k
平均合併
2 天 4 小時
30 天內合併 PR
118

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

github/codeql 的其他 Issue

查看 github/codeql 的全部 Issue

相似的 Issue

更多 DevTools Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。