Actions: imprecise action references in model data
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 38/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 停滯
- 技術堆疊
- github-actions, yaml
- 領域
- security
研究方向
從 actions/ql/lib/ext/generated/composite-actions/airbytehq_airbyte.model.yml 開始,將其 repository reference 與連結的 .github/actions/run-airbyte-ci/action.yml 進行比較。檢查其他標記為 "generated" 的產生模型檔案,以判斷相同的路徑問題是否普遍存在;完成條件是產生的項目能識別出包含每個 input 的特定巢狀 action。
由索引模型根據 Issue 內容生成。
描述
First of all, thanks for your hard work! I'm a huge fan of CodeQL, and I think support for GitHub Actions within it is amazing.
I'm filing this because I recently tried to consume some of CodeQL's "models" in an external tool (https://github.com/zizmorcore/zizmor/pull/849), and noticed what I think is a model imprecision/data quality issue.
Description
For example, actions/ql/lib/ext/generated/composite-actions/airbytehq_airbyte.model.yml:
extensions:
- addsTo:
pack: codeql/actions-all
extensible: actionsSinkModel
data:
- ["airbytehq/airbyte", "*", "input.options", "code-injection", "generated"]
- ["airbytehq/airbyte", "*", "input.subcommand", "code-injection", "generated"]
This implies that airbytehq/airbyte has a top-level action.ya?ml definition, but it doesn't: instead, it has a set of actions defined under airbytehq/airbyte/.github/actions, of which run-airbyte-ci appears to have the relevant injectable inputs:
name: "Run Dagger pipeline"
description: "Runs a given dagger pipeline"
inputs:
subcommand:
description: "Subcommand for airbyte-ci"
required: true
This appears to be true in most other model files in that directory, at least the ones marked with "generated" in their definitions.
Expected behavior
Given that the inputs in question occur in in an action that isn't at the repository root, I expected the model YAML to look roughly like this:
extensions:
- addsTo:
pack: codeql/actions-all
extensible: actionsSinkModel
data:
- ["airbytehq/airbyte/.github/actions/run-airbyte-ci", "*", "input.options", "code-injection", "generated"]
- ["airbytehq/airbyte/.github/actions/run-airbyte-ci", "*", "input.subcommand", "code-injection", "generated"]
Actual behavior
The model YAML lists airbytehq/airbyte, leaving it unclear which actions within that repository have the injectable inputs.
- 主要語言
- CodeQL
- 星號
- 10.1k
- 分支
- 2.1k
- 平均合併
- 2 天 10 小時
- 30 天內合併 PR
- 134
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
github/codeql 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 84/100
-
難度 2/5 1-3 小時 新手友好度 82/100
-
難度 2/5 1-3 小時 新手友好度 78/100
-
false-positive
難度 2/5 1-3 小時 新手友好度 70/100
-
false-positive
難度 3/5 1-2 天 新手友好度 68/100
相似的 Issue
-
Product: Azure Policy :shield: Topic: Diagnostic Settings :test_tube: Topic: Policy :pencil:
難度 1/5 1-3 小時 新手友好度 92/100
Azure/Azure-Landing-Zones#4283 · 1 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 88/100
MystenLabs/MemWal#979 · 1 則留言 ·
-
namespace operations
難度 1/5 1 小時以內 新手友好度 82/100
EclipseFdn/open-vsx.org#13384 ·
-
難度 2/5 1-3 小時 新手友好度 76/100
-
documentation
難度 2/5 半天 新手友好度 62/100
inmanta/inmanta-core#10835 ·