FunctionToString overflows on cyclic Proxy prototype chains

未關閉
  • 哪裡不對？
#25,963 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@adityareddy-dev 已經在處理了。

開始於 2026年11月4日。

  • #25964 來自 @chiliec —— 已關閉，未合併

評估

難度
4/5
預估耗時
3-5 天
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
停滯
技術堆疊
javascript, typescript
領域
devtools

研究方向

Start with functionToStringIntegration and packages/core/src/utils/object.ts, focusing on how getOriginalFunction reads __sentry_original__. Use the reproduction in the issue to investigate the cyclic Proxy case; done means the wrapped toString returns normally for that case without changing native behavior.

由索引模型根據 Issue 內容生成。

描述

Browser Bug

The patched Function.prototype.toString from functionToStringIntegration throws RangeError: Maximum call stack size exceeded for a function whose prototype chain loops back through a Proxy. Native toString returns normally for the same function. Anti-tamper and fingerprinting scripts use this kind of probe to detect patched natives.

Reported by Sergio Lombana from a customer on @sentry/[email protected] with Castle bot detection loaded. Their event has a short stack: the Sentry toString wrapper is the top frame and the frames below it are Castle's.

Root cause (high confidence for the repro, unverified for the customer's exact trigger)

The wrapper calls getOriginalFunction(this), which reads this.__sentry_original__ (packages/core/src/utils/object.ts). For a function without that own property, the read walks the prototype chain. If the chain loops back through a Proxy, the walk never ends and overflows inside the wrapper frame. Native toString never reads properties from this, so it doesn't overflow.

This still happens on develop after #25921 / #25922. Those PRs fixed the apply re-entry and huge-argument-list overflows, not this property lookup.

Reproduction

const orig = Function.prototype.toString;
const callOrig = Function.prototype.call.bind(orig);

function f() {}
Object.setPrototypeOf(f, Object.create(new Proxy(f, {})));

Function.prototype.toString.call(f); // native: 'function f() {}'

// same shape as the current wrapper on develop
Function.prototype.toString = function () {
  const o = this.__sentry_original__;
  return callOrig(o ?? this);
};

Function.prototype.toString.call(f); // RangeError: Maximum call stack size exceeded

Unknowns

  • Someone else reproduced this artificial case but couldn't trigger the error with the same Castle and SDK versions. So it's not confirmed that this is the probe Castle runs in the customer's environment.

Workaround

  • Filter the RangeError via ignoreErrors / beforeSend. Removing functionToStringIntegration can make Sentry-wrapped functions look tampered to anti-bot scripts, so it isn't recommended here.

Related: #21965, #22515, #25921, #25922

via Sergio.

--

View Session [Sentry]

主要語言
TypeScript
星號
8.8k
分支
1.9k
平均合併
1 天 20 小時
30 天內合併 PR
682

環境準備

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

getsentry/sentry-javascript 的其他 Issue

查看 getsentry/sentry-javascript 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。